Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

transfer: small improvements to authz #3460

Merged
merged 2 commits into from
Apr 18, 2023
Merged

Conversation

crodriguezvega
Copy link
Contributor

@crodriguezvega crodriguezvega commented Apr 14, 2023

Description

This PR fixes 2 out of the 3 Improvements suggested by @fedekunze here.

closes: #XXXX

Commit Message / Changelog Entry

N/A

see the guidelines for commit messages. (view raw markdown for examples)


Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

  • Targeted PR against correct branch (see CONTRIBUTING.md).
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the module structure standards and Go style guide.
  • Wrote unit and integration tests.
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/).
  • Added relevant godoc comments.
  • Provide a commit message to be used for the changelog entry in the PR description for review.
  • Re-reviewed Files changed in the Github PR explorer.
  • Review Codecov Report in the comment section below once CI passes.

@codecov-commenter
Copy link

codecov-commenter commented Apr 14, 2023

Codecov Report

Merging #3460 (2ca365d) into main (c043dbd) will increase coverage by 0.22%.
The diff coverage is 96.77%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3460      +/-   ##
==========================================
+ Coverage   78.54%   78.76%   +0.22%     
==========================================
  Files         181      181              
  Lines       12581    12589       +8     
==========================================
+ Hits         9882     9916      +34     
+ Misses       2265     2248      -17     
+ Partials      434      425       -9     
Impacted Files Coverage Δ
modules/core/keeper/msg_server.go 54.78% <50.00%> (-0.02%) ⬇️
modules/apps/29-fee/keeper/grpc_query.go 90.52% <100.00%> (+14.59%) ⬆️
...ules/apps/transfer/types/transfer_authorization.go 91.56% <100.00%> (+0.31%) ⬆️

Copy link
Member

@damiannolan damiannolan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice one! Thanks @crodriguezvega <3

Copy link
Contributor

@chatton chatton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM nice improvement!

@crodriguezvega crodriguezvega merged commit 214edaf into main Apr 18, 2023
@crodriguezvega crodriguezvega deleted the carlos/transfer-authz-nits branch April 18, 2023 07:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants