Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: adding workflow for docker build and push to main #3597

Merged
merged 5 commits into from
May 23, 2023

Conversation

damiannolan
Copy link
Member

Description

closes: #3518

Commit Message / Changelog Entry

chore: adding workflow for docker build and push to main

see the guidelines for commit messages. (view raw markdown for examples)


Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

  • Targeted PR against correct branch (see CONTRIBUTING.md).
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the module structure standards and Go style guide.
  • Wrote unit and integration tests.
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/).
  • Added relevant godoc comments.
  • Provide a commit message to be used for the changelog entry in the PR description for review.
  • Re-reviewed Files changed in the Github PR explorer.
  • Review Codecov Report in the comment section below once CI passes.

Copy link
Contributor

@DimitrisJim DimitrisJim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

Copy link
Contributor

@chatton chatton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just left 2 small suggestions

branches:
- main
paths:
- '**.go'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

one thing I would double check is that we should also build and push when this file changes, we could also add on: workflow_dispatch just to make it easy to manually trigger a build from main

@damiannolan damiannolan enabled auto-merge (squash) May 23, 2023 09:49
@damiannolan damiannolan merged commit dbbb48d into main May 23, 2023
@damiannolan damiannolan deleted the damian/3518-docker-workflow-main branch May 23, 2023 09:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create Docker image for ghcr.io/cosmos/ibc-go-simd on push to main
3 participants