update the Order check in ValidateUpgradeFields util method
#3774
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
charleenfei
changed the title
Order check in ValidateUpgradeFields util method
charleenfei
requested review from
colin-axner,
AdityaSripal and
damiannolan
as code owners
damiannolan
approved these changes
Jun 7, 2023
| @@ -278,8 +278,8 @@ func (k Keeper) validateUpgradeFields(ctx sdk.Context, proposedUpgrade types.Upg | |||
| } | |||
|
|
|||
| connectionID := proposedUpgrade.ConnectionHops[0] | |||
| connection, err := k.GetConnection(ctx, connectionID) | |||
| if err != nil { | |||
| connection, found := k.connectionKeeper.GetConnection(ctx, connectionID) | |||
There was a problem hiding this comment.
This is because k.GetConnection was returning the interface exported.ConnectionI rather than the concrete ConnectionEnd type, right? So that GetVersions() can be used below.
Should we add GetVersions() as an interface method to exported.ConnectionI? cc. @colin-axner
There was a problem hiding this comment.
yes, precisely @damiannolan, i'd be in favour of adding GetVersions(), i think it's the only method missing from the keeper methods in the ConnectionI interface
| @@ -554,7 +556,7 @@ func (suite *KeeperTestSuite) TestValidateProposedUpgradeFields() { | |||
| { | |||
| name: "change channel version", | |||
| malleate: func() { | |||
| proposedUpgrade.Version = "1.0.0" | |||
| proposedUpgrade.Version = mockUpgradeVersion | |||
There was a problem hiding this comment.
there is mock.UpgradeVersion now, can we use that?
There was a problem hiding this comment.
ah, yes, forgot about that value! i can use it.
…dateupgradefields
…ub.com:cosmos/ibc-go into charly/#3635-order-check-validateupgradefields
AdityaSripal
approved these changes
Jun 7, 2023
…dateupgradefields
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
closes: #3635
Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.
docs/) or specification (x/<module>/spec/).godoccomments.Files changedin the Github PR explorer.Codecov Reportin the comment section below once CI passes.