Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up vm entry points #4279

Merged
merged 4 commits into from
Aug 14, 2023
Merged

Conversation

DimitrisJim
Copy link
Contributor

Description

Does a couple of things that seemed sensible to me:

  • Move wasmQuery and wasmCall into vm, these are shared across files and them being in client_state mostly served to making me struggle to remember where they were.
  • any -> Concrete type.
  • Add wasmInit in a similar vein. Now all wasm* functions take the concrete msg, marshal it, call into their own respective functions and then handle the error.

closes: #XXXX

Commit Message / Changelog Entry

chore: normalize internal api for calling/querying contracts.

see the guidelines for commit messages. (view raw markdown for examples)


Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

  • Targeted PR against correct branch (see CONTRIBUTING.md).
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the module structure standards and Go style guide.
  • Wrote unit and integration tests.
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/).
  • Added relevant godoc comments.
  • Provide a commit message to be used for the changelog entry in the PR description for review.
  • Re-reviewed Files changed in the Github PR explorer.
  • Review Codecov Report in the comment section below once CI passes.

@DimitrisJim DimitrisJim changed the title Jim/wasm entry points Clean up vm entry points Aug 4, 2023
Copy link
Member

@damiannolan damiannolan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

modules/light-clients/08-wasm/types/client_state.go Outdated Show resolved Hide resolved
Copy link
Contributor

@crodriguezvega crodriguezvega left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! 👍

@crodriguezvega crodriguezvega merged commit 4f0a711 into feat/wasm-clients Aug 14, 2023
51 of 52 checks passed
@crodriguezvega crodriguezvega deleted the jim/wasm-entry-points branch August 14, 2023 11:02
@faddat faddat mentioned this pull request Sep 10, 2023
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants