Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deps: update all modules to go1.21 for upstream compability #4395

Closed
wants to merge 3 commits into from

Conversation

faddat
Copy link
Contributor

@faddat faddat commented Aug 21, 2023

Description

ref:

SDK 50 has updated to go 1.21 and this caused a compatibility problem with the upstream code for the capability module.

Commit Message / Changelog Entry

deps: update all modules to go 1.21

see the guidelines for commit messages. (view raw markdown for examples)


Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

  • Targeted PR against correct branch (see CONTRIBUTING.md).
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the module structure standards and Go style guide.
  • Wrote unit and integration tests.
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/).
  • Added relevant godoc comments.
  • Provide a commit message to be used for the changelog entry in the PR description for review.
  • Re-reviewed Files changed in the Github PR explorer.
  • Review Codecov Report in the comment section below once CI passes.

@faddat faddat mentioned this pull request Aug 21, 2023
3 tasks
@faddat
Copy link
Contributor Author

faddat commented Aug 21, 2023

This PR contains a significant error and it's best not to work with this branch further.

@faddat faddat closed this Aug 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant