Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: update channel upgrades default timeout to 10 mins #5433

Merged
merged 3 commits into from
Dec 18, 2023
Merged

chore: update channel upgrades default timeout to 10 mins #5433

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
db9dee5
chore: update channel upgrades default timeout to 10 mins
damiannolan Dec 18, 2023
8d00c09
Merge branch '04-channel-upgrades' into damian/4513-upgrade-timeouts
damiannolan Dec 18, 2023
7bad1f6
chore: make lint-fix
damiannolan Dec 18, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions modules/core/04-channel/types/params.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,9 +7,10 @@ import (
clienttypes "github.com/cosmos/ibc-go/v8/modules/core/02-client/types"
)

// TODO: determine sane default value for upgrade timeout.

var DefaultTimeout = NewTimeout(clienttypes.ZeroHeight(), uint64(time.Hour.Nanoseconds()))
// DefaultTimeout defines a default parameter for the channel upgrade protocol.
// It allows relayers a window in which they can flush all in-flight packets on a channel before completing the upgrade handshake.
// This parameter can be overridden by a valid authority using the UpdateChannelParams rpc.
var DefaultTimeout = NewTimeout(clienttypes.ZeroHeight(), uint64(10*time.Minute.Nanoseconds()))

// NewParams creates a new parameter configuration for the channel submodule
func NewParams(upgradeTimeout Timeout) Params {
Expand Down
Loading