Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: include transaction response in ics27 channel acknowledgement (backport #811) #838

Merged
merged 1 commit into from
Feb 2, 2022

Commits on Feb 2, 2022

  1. refactor: include transaction response in ics27 channel acknowledgeme…

    …nt (#811)
    
    ## Description
    
    ref: #701
    
    ---
    
    Before we can merge this PR, please make sure that all the following items have been
    checked off. If any of the checklist items are not applicable, please leave them but
    write a little note why.
    
    - [x] Targeted PR against correct branch (see [CONTRIBUTING.md](https://github.com/cosmos/ibc-go/blob/master/CONTRIBUTING.md#pr-targeting))
    - [x] Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
    - [x] Code follows the [module structure standards](https://github.com/cosmos/cosmos-sdk/blob/master/docs/building-modules/structure.md).
    - [x] Wrote unit and integration [tests](https://github.com/cosmos/ibc-go/blob/master/CONTRIBUTING.md#testing)
    - [x] Updated relevant documentation (`docs/`) or specification (`x/<module>/spec/`)
    - [x] Added relevant `godoc` [comments](https://blog.golang.org/godoc-documenting-go-code).
    - [x] Added a relevant changelog entry to the `Unreleased` section in `CHANGELOG.md`
    - [x] Re-reviewed `Files changed` in the Github PR explorer
    - [x] Review `Codecov Report` in the comment section below once CI passes
    
    (cherry picked from commit 6c48f7e)
    colin-axner authored and mergify-bot committed Feb 2, 2022
    Configuration menu
    Copy the full SHA
    b53d06c View commit details
    Browse the repository at this point in the history