Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: add defensive check to ensure metadata does not change when reopening an active channel #847

Merged
merged 14 commits into from
Feb 8, 2022
Merged

chore: add defensive check to ensure metadata does not change when reopening an active channel #847

merged 14 commits into from
Feb 8, 2022

Commits on Feb 3, 2022

  1. add defensive check to ensure metadata does not change when reopening… 

    … an active channel
    @colin-axner
    colin-axner committed Feb 3, 2022
    Configuration menu
    Copy the full SHA
    a0386ec View commit details
    Browse the repository at this point in the history

  2. Merge branch 'main' into colin/795-reopen-active-check

    @colin-axner
    colin-axner committed Feb 3, 2022
    Configuration menu
    Copy the full SHA
    e67068d View commit details
    Browse the repository at this point in the history

  3. add previous metadata check to onchanopentry

    @colin-axner
    colin-axner committed Feb 3, 2022
    Configuration menu
    Copy the full SHA
    5521ee3 View commit details
    Browse the repository at this point in the history

  4. readjust handshake checks to use helper function, remove tests becaus… 

    …e they cannot be reached
    @colin-axner
    colin-axner committed Feb 3, 2022
    Configuration menu
    Copy the full SHA
    1d5bf68 View commit details
    Browse the repository at this point in the history

  5. add tests for IsPreviousMetadataEqual

    @colin-axner
    colin-axner committed Feb 3, 2022
    Configuration menu
    Copy the full SHA
    21adb6c View commit details
    Browse the repository at this point in the history

  6. Merge branch 'colin/795-reopen-active-check' of github.com:cosmos/ibc… 

    …-go into colin/795-reopen-active-check
    @colin-axner
    colin-axner committed Feb 3, 2022
    Configuration menu
    Copy the full SHA
    2f2f4dc View commit details
    Browse the repository at this point in the history

  7. fix bug

    @colin-axner
    colin-axner committed Feb 3, 2022
    Configuration menu
    Copy the full SHA
    3fdc6de View commit details
    Browse the repository at this point in the history

Commits on Feb 7, 2022

  1. use correct version in OpenInit handshake

    @colin-axner
    colin-axner committed Feb 7, 2022
    Configuration menu
    Copy the full SHA
    3559f2d View commit details
    Browse the repository at this point in the history

  2. Apply Aditya's error improvement comments

    @colin-axner
    colin-axner committed Feb 7, 2022
    Configuration menu
    Copy the full SHA
    146c7fa View commit details
    Browse the repository at this point in the history

  3. Update modules/apps/27-interchain-accounts/types/metadata.go 

    Co-authored-by: Damian Nolan <[email protected]>
    @colin-axner @damiannolan
    colin-axner and damiannolan committed Feb 7, 2022
    Configuration menu
    Copy the full SHA
    bebbfa7 View commit details
    Browse the repository at this point in the history

  4. Merge branch 'main' into colin/795-reopen-active-check

    @colin-axner
    colin-axner committed Feb 7, 2022
    Configuration menu
    Copy the full SHA
    e7b48ca View commit details
    Browse the repository at this point in the history

Commits on Feb 8, 2022

  1. test: add tests for previous metadata being different

    @colin-axner
    colin-axner committed Feb 8, 2022
    Configuration menu
    Copy the full SHA
    0f422e2 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'colin/795-reopen-active-check' of github.com:cosmos/ibc… 

    …-go into colin/795-reopen-active-check
    @colin-axner
    colin-axner committed Feb 8, 2022
    Configuration menu
    Copy the full SHA
    4c2c0f3 View commit details
    Browse the repository at this point in the history

  3. Merge branch 'main' into colin/795-reopen-active-check

    @colin-axner
    colin-axner committed Feb 8, 2022
    Configuration menu
    Copy the full SHA
    42557b3 View commit details
    Browse the repository at this point in the history