Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Derive serde::{Serialize, Deserialize} for U256 #41

Closed
5 tasks
hu55a1n1 opened this issue Jun 9, 2022 · 0 comments · Fixed by informalsystems/hermes#2280
Closed
5 tasks

Derive serde::{Serialize, Deserialize} for U256 #41

hu55a1n1 opened this issue Jun 9, 2022 · 0 comments · Fixed by informalsystems/hermes#2280

Comments

@hu55a1n1
Copy link
Contributor

hu55a1n1 commented Jun 9, 2022

Summary

The bigint U256 doesn't implement serde::{Serialize, Deserialize}. And for this reason, the Amount type also can't derive them.

Proposal

Reexport primitive_types::U256 (which already has these impls and now supports no_std) instead of using uint::construct_uint!() to create our U256 type.

Acceptance Criteria

U256 implements serde::{Serialize, Deserialize}.

For Admin Use

  • Not duplicate issue
  • Appropriate labels applied
  • Appropriate milestone (priority) applied
  • Appropriate contributors tagged
  • Contributor assigned/self-assigned
@hu55a1n1 hu55a1n1 mentioned this issue Jun 9, 2022
Merged
6 tasks
@hu55a1n1 hu55a1n1 transferred this issue from informalsystems/hermes Sep 29, 2022
livelybug referenced this issue in octopus-network/ibc-rs Oct 14, 2022
@DaviRain-Su @en
Mock a grandpa client (#41)
078480a 
* Add Ics10 Grandpa Client

* update ..

* Update ...

* Update Grandpa client

* Update client_def.rs

Co-authored-by: DaviRain-Su <[email protected]>
Co-authored-by: Yuanchao Sun <[email protected]>
@plafer plafer mentioned this issue Feb 17, 2023
Merged
7 tasks
shuoer86 pushed a commit to shuoer86/ibc-rs that referenced this issue Nov 4, 2023
@ethanfrey
Merge pull request cosmos#41 from DaviRain-Su/suooprt-no-std
e0046b8 
support ics23 no-std
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

ICS20 API improvements informalsystems/hermes
1 participant
@hu55a1n1