Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reorganize sections for clarity #84

Closed
cwgoes opened this issue May 2, 2019 · 6 comments · Fixed by #97
Closed

Reorganize sections for clarity #84

cwgoes opened this issue May 2, 2019 · 6 comments · Fixed by #97
Assignees
@cwgoes
Labels
meta Issues or proposals about the ICS process.

Comments

@cwgoes
Copy link
Contributor

cwgoes commented May 2, 2019

Ref https://github.com/cosmos/ics/pull/20/files#r279727245

(we should do this consistently across specs)
@cwgoes cwgoes added the meta Issues or proposals about the ICS process. label May 2, 2019
@cwgoes cwgoes self-assigned this May 2, 2019
@cwgoes cwgoes mentioned this issue May 2, 2019
Merged
@cwgoes
Copy link
Contributor Author

cwgoes commented May 3, 2019

Also change # to ## (and all subsequent levels likewise)

@cwgoes cwgoes mentioned this issue May 3, 2019
Merged
@cwgoes cwgoes closed this as completed in c142230 May 11, 2019
This was referenced May 11, 2019
Merged
Closed
Merged
Merged
Closed
cwgoes added a commit that referenced this issue May 11, 2019
@cwgoes
Reformat per #84
bf24017
@gamarin2
Copy link

why close?

@cwgoes
Copy link
Contributor Author

cwgoes commented May 13, 2019 •
edited
Loading

why close?

Because I made the modifications you requested on master, and noted this issue on outstanding PRs.

Did I miss anything?

@gamarin2
Copy link

It's just that I've seen many PRs where the changes have not been made yet. If this PR is closed we might forget to actually make the change on the PRs

@cwgoes
Copy link
Contributor Author

cwgoes commented May 13, 2019

Ok!

@cwgoes cwgoes reopened this May 13, 2019
cwgoes added a commit that referenced this issue May 15, 2019
@cwgoes
Reformat per #84
6750543
This was referenced May 21, 2019
Closed
Merged
@cwgoes
Copy link
Contributor Author

cwgoes commented May 21, 2019 •
edited
Loading

(sub-section and sub-sub-section compliance is now checked automatically in CI)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@cwgoes cwgoes

Labels
meta Issues or proposals about the ICS process.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add CI to check sections cosmos/ibc
2 participants
@gamarin2 @cwgoes