support ics23 no-std #41
Conversation
|
Interesting and thank you for the contribution. I will look later. In the meantime, could you update the CI scripts so they will run tests in no_std mode ( |
Ok ah, I'll see how to set it up. |
|
Thank you. |
|
I just checked out your branch and tried running no_std tests:
This produces a number of errors. Most are either:
with suggestions for |
|
Can you add these lines to the end of the circleCI job? - run:
name: Build all targets in no_std
command: cargo build --all --no-default-features
- run:
name: Run all tests with no-std
command: cargo test --all --no-default-features |
It doesn't seem to work. |
Exactly, the tests fail to compile (build works, but test code seems to not be no_std compatible). |
I solved this problem, see if you can pass it. |
|
@ethanfrey Hi, Can you merge this PR? |
There was a problem hiding this comment.
Sorry for the late review. I was on vacation the last two weeks.
Thank you for adding no-std to the CI and getting tests to pass. I created a follow up issue #42 that it would be great if you could look at sometime. But for now, I will merge your changes to unblock you. It would be nice if we could tackle at least some of #42 before I tag and push a new crate
| @@ -230,6 +236,7 @@ mod tests { | |||
| pub value: Option<Vec<u8>>, | |||
| } | |||
|
|
|||
| #[cfg(feature = "std")] | |||
There was a problem hiding this comment.
Okay, so these tests are not run in no_std mode.
It gets the code to pass (and I guess I can merge it), but it would be nice to run the whole test suite with no-std
There was a problem hiding this comment.
I think it is necessary to test here in the std environment, for File ,io and some other libraries are not available in core and alloc, but only in the standard library.
Relate tourtial: https://docs.rust-embedded.org/book/intro/no-std.html
There was a problem hiding this comment.
Ah... you are very right.
I guess none of these work in no-std but it would be nice to have equivalent tests.
Maybe you can use include_bytes, and then get rid of all the load_file stuff as well (and have tests work in both environments)
| @@ -1,3 +1,11 @@ | |||
| #![cfg_attr(not(feature = "std"), no_std)] | |||
| #![allow(dead_code)] | |||
There was a problem hiding this comment.
funny smell here.
I guess some code is only exposed via std or no-std?
We could also just conditionally expose it.
There was a problem hiding this comment.
Yes, compile by using #![cfg_attr(not(feature = "std"), no_std)] to conditionally select between std and no_std.
Here some tourtial: https://justjjy.com/Rust-no-std
There was a problem hiding this comment.
I was commenting on #![allow(dead_code)], which I removed in another PR
Support Ics23 rust no-std features.