This repository has been archived by the owner on Sep 20, 2023. It is now read-only.
bumps #145
Closed
bumps #145
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
Merged
|
This PR is blocked by cosmos/ibc-go#2568 |
|
@catShaark not anymore :). But this PR uses my repo and one of Notionals so it will be better if we get these merged first:
Then we can get rid of the notional-labs/ibc-go/v6 replace line. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Upgrades interchain-accounts-demo to match github.com/cosmos/ibc-go@main
I think that this is likely to fail, but is better than nothing.
If anyone knows how to fix, feel free to take over the branch by pulling mine and PRing into here with fixes.
Locally, it fails on make test.
I notice that we don't have that here, I'll add a ci job to run that in a separate pr.
To make testing and verification easier, this PR contains:
When those are merged, they will be removed from the review scope of this PR.