feat: remove consumer panic when ccv channel is closed #1127
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shaspitz
changed the title
shaspitz
commented
Jul 11, 2023
| @@ -213,30 +211,3 @@ func (s *CCVTestSuite) checkConsumerChainIsRemoved(chainID string, checkChannel | |||
| s.Require().Empty(slashData) | |||
| s.Require().Empty(vscMaturedData) | |||
| } | |||
|
|
|||
| // TestProviderChannelClosed checks that a consumer chain panics | |||
There was a problem hiding this comment.
This test would no longer be relevant
mpoke
approved these changes
Jul 12, 2023
sainoe
approved these changes
Jul 12, 2023
MSalopek
approved these changes
Jul 12, 2023
mergify bot
pushed a commit
that referenced
this pull request
Jul 12, 2023
* rm panic * rm tests * Update CHANGELOG.md * update comment (cherry picked from commit 1412923) # Conflicts: # tests/integration/stop_consumer.go
shaspitz
added a commit
that referenced
this pull request
Jul 12, 2023
* rm panic * rm tests * Update CHANGELOG.md * update comment
shaspitz
added a commit
that referenced
this pull request
Jul 12, 2023
insumity
pushed a commit
that referenced
this pull request
Jul 24, 2023
* rm panic * rm tests * Update CHANGELOG.md * update comment
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Removes the panic in the consumer ccv module which would occur when the CCV channel has been closed. This will be particularly desirable for Stride where the chain could run as a POA chain if such an emergency scenario happens during or after the standalone to consumer changeover.
This PR should not require coordinated upgrade to the best of my knowledge, in that the panic would only execute in an emergency situation for a consumer. The change should be included in the version of Stride that will be used in the upcoming changeover.
Related to #627
Author Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...
!to the type prefix if state-machine breaking change (i.e., requires coordinated upgrade)CHANGELOG.mdReviewers Checklist
All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.
I have...
!in the type prefix if API or client breaking change