Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add flag for reading test traces and add them in the CI #1315

Merged
merged 4 commits into from
Sep 19, 2023
Merged

Add flag for reading test traces and add them in the CI #1315

merged 4 commits into from
Sep 19, 2023

Conversation

p-offtermatt
Copy link
Contributor

Description

Closes: Part of #1265

Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • Included the correct type prefix in the PR title
  • Targeted the correct branch (see PR Targeting)
  • Provided a link to the relevant issue or specification
  • Reviewed "Files changed" and left comments if necessary
  • Confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • Confirmed the correct type prefix in the PR title
  • Confirmed all author checklist items have been addressed
  • Confirmed that this PR does not change production code

@github-actions github-actions bot added the C:Testing Assigned automatically by the PR labeler label Sep 19, 2023
@mergify
Copy link
Contributor

mergify bot commented Sep 19, 2023

⚠️ The sha of the head commit of this PR conflicts with #1314. Mergify cannot evaluate rules on this PR. ⚠️

@p-offtermatt p-offtermatt changed the base branch from main to ph/json-marshal September 19, 2023 11:18
@github-actions github-actions bot added C:Build Assigned automatically by the PR labeler C:CI Assigned automatically by the PR labeler labels Sep 19, 2023
@p-offtermatt p-offtermatt merged commit 14833c3 into ph/json-marshal Sep 19, 2023
5 checks passed
@p-offtermatt p-offtermatt deleted the ph/trace-flag branch September 19, 2023 11:21
@mergify
Copy link
Contributor

mergify bot commented Sep 19, 2023

⚠️ The sha of the head commit of this PR conflicts with #1314. Mergify cannot evaluate rules on this PR. ⚠️

1 similar comment
@mergify
Copy link
Contributor

mergify bot commented Sep 19, 2023

⚠️ The sha of the head commit of this PR conflicts with #1314. Mergify cannot evaluate rules on this PR. ⚠️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
C:Build Assigned automatically by the PR labeler C:CI Assigned automatically by the PR labeler C:Testing Assigned automatically by the PR labeler
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@p-offtermatt