Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Key assignment #515

Merged
merged 64 commits into from
Dec 7, 2022
Merged

Key assignment #515

merged 64 commits into from
Dec 7, 2022

Commits on Nov 23, 2022

  1. add MsgAssignConsumerKey

    @mpoke
    mpoke committed Nov 23, 2022
    Configuration menu
    Copy the full SHA
    f83c731 View commit details
    Browse the repository at this point in the history

  2. add MsgAssignConsumerKey

    @mpoke
    mpoke committed Nov 23, 2022
    Configuration menu
    Copy the full SHA
    084ef62 View commit details
    Browse the repository at this point in the history

  3. fix package name

    @mpoke
    mpoke committed Nov 23, 2022
    Configuration menu
    Copy the full SHA
    ebd0398 View commit details
    Browse the repository at this point in the history

  4. add keys

    @mpoke
    mpoke committed Nov 23, 2022
    Configuration menu
    Copy the full SHA
    020f285 View commit details
    Browse the repository at this point in the history

  5. add keeper methods for key assignment

    @mpoke
    mpoke committed Nov 23, 2022
    Configuration menu
    Copy the full SHA
    75bf2a1 View commit details
    Browse the repository at this point in the history

  6. handle MsgAssignConsumerKey

    @mpoke
    mpoke committed Nov 23, 2022
    Configuration menu
    Copy the full SHA
    ac30f74 View commit details
    Browse the repository at this point in the history

  7. map addresses in slash requests

    @mpoke
    mpoke committed Nov 23, 2022
    Configuration menu
    Copy the full SHA
    6707ac9 View commit details
    Browse the repository at this point in the history

  8. prune old consumer addresses

    @mpoke
    mpoke committed Nov 23, 2022
    Configuration menu
    Copy the full SHA
    26ff35a View commit details
    Browse the repository at this point in the history

  9. move AssignConsumerKey logic to keeper

    @mpoke
    mpoke committed Nov 23, 2022
    Configuration menu
    Copy the full SHA
    6974766 View commit details
    Browse the repository at this point in the history

  10. update consumer initial valset

    @mpoke
    mpoke committed Nov 23, 2022
    Configuration menu
    Copy the full SHA
    35bb100 View commit details
    Browse the repository at this point in the history

  11. add ApplyKeyAssignmentToValUpdates

    @mpoke
    mpoke committed Nov 23, 2022
    Configuration menu
    Copy the full SHA
    09fd054 View commit details
    Browse the repository at this point in the history

  12. fix client creation

    @mpoke
    mpoke committed Nov 23, 2022
    Configuration menu
    Copy the full SHA
    098a4e6 View commit details
    Browse the repository at this point in the history

  13. do not check init valset on consumer

    @mpoke
    mpoke committed Nov 23, 2022
    Configuration menu
    Copy the full SHA
    f8cd226 View commit details
    Browse the repository at this point in the history

  14. clean state on val removal

    @mpoke
    mpoke committed Nov 23, 2022
    Configuration menu
    Copy the full SHA
    533c6cf View commit details
    Browse the repository at this point in the history

  15. fix TestAssignConsensusKeyForConsumerChain

    @mpoke
    mpoke committed Nov 23, 2022
    Configuration menu
    Copy the full SHA
    3091bd1 View commit details
    Browse the repository at this point in the history

  16. delete on val removal

    @mpoke
    mpoke committed Nov 23, 2022
    Configuration menu
    Copy the full SHA
    b85e87c View commit details
    Browse the repository at this point in the history

  17. remove reverse mapping on val removal

    @mpoke
    mpoke committed Nov 23, 2022
    Configuration menu
    Copy the full SHA
    595c3eb View commit details
    Browse the repository at this point in the history

  18. remove pending key assignment in EndBlock

    @mpoke
    mpoke committed Nov 23, 2022
    Configuration menu
    Copy the full SHA
    1c2e696 View commit details
    Browse the repository at this point in the history

  19. add query endpoints 

    add summary of indexes
change ConsumerValidatorByVscID to ConsumerAddrsToPrune
    @jtremback
    jtremback committed Nov 23, 2022
    Configuration menu
    Copy the full SHA
    f5be337 View commit details
    Browse the repository at this point in the history

  20. Refactor AssignConsumerKey for clarity (IMO)

    @jtremback
    jtremback committed Nov 23, 2022
    1 Configuration menu
    Copy the full SHA
    40b3bc9 View commit details
    Browse the repository at this point in the history

  21. finish key assignment genesis code- untested

    @jtremback
    jtremback committed Nov 23, 2022
    Configuration menu
    Copy the full SHA
    19cc625 View commit details
    Browse the repository at this point in the history

  22. FIxed mocks compile issue - not sure if it works right though.

    @jtremback
    jtremback committed Nov 23, 2022
    Configuration menu
    Copy the full SHA
    3270302 View commit details
    Browse the repository at this point in the history

Commits on Nov 24, 2022

  1. add test for init and export genesis

    @jtremback
    jtremback committed Nov 24, 2022
    Configuration menu
    Copy the full SHA
    87fff1b View commit details
    Browse the repository at this point in the history

  2. set after get in AssignConsumerKey

    @mpoke
    mpoke committed Nov 24, 2022
    Configuration menu
    Copy the full SHA
    d7f3be4 View commit details
    Browse the repository at this point in the history

  3. enable AssignConsumerKey to be called twice

    @mpoke
    mpoke committed Nov 24, 2022
    Configuration menu
    Copy the full SHA
    4a4dce2 View commit details
    Browse the repository at this point in the history

  4. remove key assignment on chain removal

    @mpoke
    mpoke committed Nov 24, 2022
    Configuration menu
    Copy the full SHA
    a621b9b View commit details
    Browse the repository at this point in the history

  5. apply some review comments

    @mpoke
    mpoke committed Nov 24, 2022
    Configuration menu
    Copy the full SHA
    cf1bc61 View commit details
    Browse the repository at this point in the history

  6. fix bug: two validator with same consumer key

    @mpoke
    mpoke committed Nov 24, 2022
    Configuration menu
    Copy the full SHA
    86c5979 View commit details
    Browse the repository at this point in the history

  7. rename key: ConsumerValidatorsByVscIDBytePrefix -> ConsumerAddrsToPru… 

    …neBytePrefix
    @mpoke
    mpoke committed Nov 24, 2022
    Configuration menu
    Copy the full SHA
    c050cc8 View commit details
    Browse the repository at this point in the history

  8. PendingKeyAssignment -> KeyAssignmentReplacements

    @mpoke
    mpoke committed Nov 24, 2022
    Configuration menu
    Copy the full SHA
    605d562 View commit details
    Browse the repository at this point in the history

  9. msg.ProviderAddr is a validator addr

    @mpoke
    mpoke committed Nov 24, 2022
    Configuration menu
    Copy the full SHA
    0c9f620 View commit details
    Browse the repository at this point in the history

  10. fix: key assignment genesis tests (#517) 

    * Fix consumer init genesis test

* fix provider genesis tests

* fix key assignement handler

* fix linter

* fix merge conflict

* fix ProviderValidatorAddress

* remove unused expectation

Co-authored-by: Marius Poke <[email protected]>
    @sainoe @mpoke
    sainoe and mpoke authored Nov 24, 2022
    Configuration menu
    Copy the full SHA
    f0ae261 View commit details
    Browse the repository at this point in the history

  11. add key assignment CRUD operations unit tests (#516) 

    * test val consumer key related CRUD

* test val consumer addr related CRUD

* test pending key assignments related CRUD

* refactor after review session

* refactor after review session

* add prune key CRUD tests

* renamings in testfiles
    @MSalopek
    MSalopek authored Nov 24, 2022
    Configuration menu
    Copy the full SHA
    d64f7a6 View commit details
    Browse the repository at this point in the history

Commits on Nov 25, 2022

  1. improve KeyAssignmentReplacement set and get

    @mpoke
    mpoke committed Nov 25, 2022
    Configuration menu
    Copy the full SHA
    9e84264 View commit details
    Browse the repository at this point in the history

  2. remove ApplyKeyAssignmentToInitialValset (redundant)

    @mpoke
    mpoke committed Nov 25, 2022
    Configuration menu
    Copy the full SHA
    5872f93 View commit details
    Browse the repository at this point in the history

  3. add invariant to docstring of AppendConsumerAddrsToPrune

    @mpoke
    mpoke committed Nov 25, 2022
    Configuration menu
    Copy the full SHA
    c396b3f View commit details
    Browse the repository at this point in the history

  4. fix address conversion

    @mpoke
    mpoke committed Nov 25, 2022
    Configuration menu
    Copy the full SHA
    e772dfb View commit details
    Browse the repository at this point in the history

  5. Merge branch 'main' into marius/key-assignment

    @mpoke
    mpoke authored Nov 25, 2022
    Configuration menu
    Copy the full SHA
    7fbbc76 View commit details
    Browse the repository at this point in the history

  6. adding e2e tests

    @mpoke
    mpoke committed Nov 25, 2022
    Configuration menu
    Copy the full SHA
    6d8cd10 View commit details
    Browse the repository at this point in the history

  7. fix linter

    @mpoke
    mpoke committed Nov 25, 2022
    Configuration menu
    Copy the full SHA
    aca9578 View commit details
    Browse the repository at this point in the history

Commits on Nov 28, 2022

  1. add queries; setup integration tests (#519) 

    * add queries; setup integration testse

* test key assignment before chain start

* fix state queries; refactor

* rm extra comment

* rm unused action field

* bump voting times in all tests

* add provider address query to tests
    @MSalopek
    MSalopek authored Nov 28, 2022
    Configuration menu
    Copy the full SHA
    8641273 View commit details
    Browse the repository at this point in the history

  2. Adds some very basic random testing and unit tests (#522) 

    * Adds imports

* Does multi iterations: fails!

* Handle errs

* checkpoint debug

* Pre introduce dynamic mock

* Issue seems to be resolved

* Removes prints in key asisgn

* Removes debug, pre reintroduce all test features

* Fix some magic numbers, bring back prune check

* Pre rework initial assignments

* Refactor and tidyup

* Better docs, clarity, org

Co-authored-by: Daniel <[email protected]>
    @danwt
    danwt and Daniel authored Nov 28, 2022
    Configuration menu
    Copy the full SHA
    eb7ff69 View commit details
    Browse the repository at this point in the history

  3. Enable key assignment testing for all e2e tests (#524) 

    * split CCVTestSuite.setupCallback in two

* pre-assign keys for all vals of first consumer

* fix linter

* remove TestConsumerGenesis
    @mpoke
    mpoke authored Nov 28, 2022
    Configuration menu
    Copy the full SHA
    5820c66 View commit details
    Browse the repository at this point in the history

  4. Merge branch 'main' into marius/key-assignment

    @jtremback
    jtremback authored Nov 28, 2022
    Configuration menu
    Copy the full SHA
    7616700 View commit details
    Browse the repository at this point in the history

Commits on Dec 1, 2022

  1. Merge branch 'main' into marius/key-assignment

    @danwt
    danwt authored Dec 1, 2022
    Configuration menu
    Copy the full SHA
    a1f592a View commit details
    Browse the repository at this point in the history

  2. adding ADR

    @mpoke
    mpoke committed Dec 1, 2022
    Configuration menu
    Copy the full SHA
    0568ce8 View commit details
    Browse the repository at this point in the history

  3. Merge branch 'marius/key-assignment' of github.com:cosmos/interchain-… 

    …security into marius/key-assignment
    @mpoke
    mpoke committed Dec 1, 2022
    Configuration menu
    Copy the full SHA
    561c567 View commit details
    Browse the repository at this point in the history

Commits on Dec 2, 2022

  1. move handler.go outside client/

    @mpoke
    mpoke committed Dec 2, 2022
    Configuration menu
    Copy the full SHA
    0d3123f View commit details
    Browse the repository at this point in the history

  2. replace [][]byte with AddressList

    @mpoke
    mpoke committed Dec 2, 2022
    Configuration menu
    Copy the full SHA
    1bec53f View commit details
    Browse the repository at this point in the history

  3. remove IterateAllConsumerAddrsToPrune; not needed

    @mpoke
    mpoke committed Dec 2, 2022
    Configuration menu
    Copy the full SHA
    23d4b54 View commit details
    Browse the repository at this point in the history

  4. apply review suggestions

    @mpoke
    mpoke committed Dec 2, 2022
    Configuration menu
    Copy the full SHA
    0c29fb4 View commit details
    Browse the repository at this point in the history

  5. fix merge conflicts

    @mpoke
    mpoke committed Dec 2, 2022
    Configuration menu
    Copy the full SHA
    bb4e1ea View commit details
    Browse the repository at this point in the history

  6. fix linter

    @mpoke
    mpoke committed Dec 2, 2022
    Configuration menu
    Copy the full SHA
    637fc55 View commit details
    Browse the repository at this point in the history

  7. Danwt/key assignment slash test (#545) 

    * cp

* wip

* note

* cp

* Adds slash test

Co-authored-by: Daniel <[email protected]>
    @danwt
    danwt and Daniel authored Dec 2, 2022
    Configuration menu
    Copy the full SHA
    ca05578 View commit details
    Browse the repository at this point in the history

Commits on Dec 5, 2022

  1. Merge branch 'main' into marius/key-assignment

    @danwt
    danwt authored Dec 5, 2022
    Configuration menu
    Copy the full SHA
    f1f5ed4 View commit details
    Browse the repository at this point in the history

  2. Fixes #503 prevents two key assignment key overlap security issues (#556 

    )

* Deletes out of date duplicate code

* Adds check that validator with key does not already exist

* Partially adjust assign unit test

* Finishes adjusting unit

* Updates stress test to never find a validator

* Improves comment

* Fixes handler_test

* Adds validatorI iterator to expected keeper

* Implements AfterValidatorCreated hook

* Names

* Simplifies validator query

* Adds hooks test

* Remove TODO

* Fix random sim test

Co-authored-by: Daniel <[email protected]>
    @danwt
    danwt and Daniel authored Dec 5, 2022
    Configuration menu
    Copy the full SHA
    0fe2305 View commit details
    Browse the repository at this point in the history

Commits on Dec 6, 2022

  1. Bump AssignConsumerKey comment

    Daniel committed Dec 6, 2022
    Configuration menu
    Copy the full SHA
    a519d12 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'main' into marius/key-assignment

    @danwt
    danwt authored Dec 6, 2022
    Configuration menu
    Copy the full SHA
    a833334 View commit details
    Browse the repository at this point in the history

  3. improve comments for iterators

    @mpoke
    mpoke committed Dec 6, 2022
    Configuration menu
    Copy the full SHA
    da08407 View commit details
    Browse the repository at this point in the history

  4. Masa/key assignment integration tests amend (#548) 

    * handle gosec false positive

* add err checks for key assign; rm multiconsumer tests

* guestimate block window for keyswaps in happyPeth

* start multiconsumer with flag
    @MSalopek
    MSalopek authored Dec 6, 2022
    Configuration menu
    Copy the full SHA
    ab43903 View commit details
    Browse the repository at this point in the history

Commits on Dec 7, 2022

  1. remove node_modules

    @mpoke
    mpoke committed Dec 7, 2022
    Configuration menu
    Copy the full SHA
    f87973d View commit details
    Browse the repository at this point in the history

  2. fix comment

    @mpoke
    mpoke committed Dec 7, 2022
    Configuration menu
    Copy the full SHA
    26ddbf6 View commit details
    Browse the repository at this point in the history

  3. fix merge conflicts

    @mpoke
    mpoke committed Dec 7, 2022
    Configuration menu
    Copy the full SHA
    6e0ca7f View commit details
    Browse the repository at this point in the history

  4. Merge branch 'main' into marius/key-assignment

    @mpoke
    mpoke authored Dec 7, 2022
    Configuration menu
    Copy the full SHA
    530cdcb View commit details
    Browse the repository at this point in the history