Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move info about testing from README to testing.md #616

Merged
merged 4 commits into from
Dec 22, 2022
Merged

Move info about testing from README to testing.md #616

merged 4 commits into from
Dec 22, 2022

Conversation

mpoke
Copy link
Contributor

@mpoke mpoke commented Dec 20, 2022 •
edited
Loading

Description

Move info about testing from README to testing.md

Type of change

  • Docs: Adds documentation

@shaspitz
Copy link
Contributor

What is the advantage of a wiki over git tracking these test instructions? Imo it's nice to see req changes to testing instructions

@mpoke
Copy link
Contributor Author

mpoke commented Dec 20, 2022

What is the advantage of a wiki over git tracking these test instructions? Imo it's nice to see req changes to testing instructions

Fair point. I just wanted to clean up our README. Maybe we should have a testing.md file into docs that contains all this info. What do you think?

@shaspitz
Copy link
Contributor

What is the advantage of a wiki over git tracking these test instructions? Imo it's nice to see req changes to testing instructions

Fair point. I just wanted to clean up our README. Maybe we should have a testing.md file into docs that contains all this info. What do you think?

Yea this seems solid to me 👍, the main readme could then just link to the testing.md

@mpoke mpoke changed the title Move info about testing from README to wiki Move info about testing from README to testing.md Dec 21, 2022
shaspitz
shaspitz approved these changes Dec 21, 2022
View reviewed changes
Copy link
Contributor

@shaspitz shaspitz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mpoke mpoke requested a review from MSalopek December 21, 2022 16:05
MSalopek
MSalopek approved these changes Dec 22, 2022
View reviewed changes
Copy link
Contributor

@MSalopek MSalopek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@mpoke mpoke merged commit 57b47af into main Dec 22, 2022
@mpoke mpoke deleted the mpoke/readme-testing branch December 22, 2022 16:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MSalopek MSalopek MSalopek approved these changes

@shaspitz shaspitz shaspitz approved these changes

@jtremback jtremback Awaiting requested review from jtremback

@sainoe sainoe Awaiting requested review from sainoe

@danwt danwt Awaiting requested review from danwt

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mpoke @shaspitz @MSalopek