disable consumer initiated slashing + fix slash acks bug #692
Conversation
… on the consumers
|
Imo |
|
@mpoke do you think it's appropriate to remove |
This test was removed |
| infractionHeight, _ := k.getMappedInfractionHeight(ctx, chainID, data.ValsetUpdateId) | ||
|
|
||
| // TODO: would be better to have a warning, but there is no Warn() function | ||
| k.Logger(ctx).Error("SlashPacket received for double-signing", |
There was a problem hiding this comment.
Maybe add an event on the provider so double-signs can be queried at a later time.
|
e2e/UTs are fixed ✅ |
|
Diff-tests updated ✅ |
sainoe
requested review from
jtremback,
mpoke,
mmulji-ic,
glnro and
yaruwangway
as code owners
|
Looks good, except for changes required in model.ts line 428. Please fix it and then this can be merged |
Naming refactors can be included in a future PR. See #706 |
* refactor Slash processing on provider and consumer * add unittest for slash acks correctness * update using review comments * fix and tests * relay test * smol --------- Co-authored-by: Matija Salopek <[email protected]> Co-authored-by: MSalopek <[email protected]>
shaspitz
changed the title
|
#708 should have been merged into main after this PR, all good tho, this PR will close two issues now. Description updated |
Description
Disable consumer-initiated slashing and also jailing for double-signing evidence.
Also includes #708
Linked issues
Closes: #689 and #693
Type of change
If you've checked more than one of the first three boxes, consider splitting this PR into multiple PRs!
Feature: Changes and/or adds code behavior, irrelevant to bug fixesRefactor: Changes existing code style, naming, structure, etc.Regression tests
New behavior tests
All tests should be updated to follow the new expected behavior when the consumer-initiated slashing feature is disabled.