[sdk50] Lint the go relayer like IBC-go #1274
Conversation
faddat
requested review from
jackzampolin,
jtieri,
boojamya and
mark-rushakoff
as code owners
| @@ -40,14 +41,15 @@ func StartDebugServer(ctx context.Context, log *zap.Logger, ln net.Listener, reg | |||
| mux.Handle("/relayer/metrics", promhttp.HandlerFor(registry, promhttp.HandlerOpts{})) | |||
|
|
|||
| srv := &http.Server{ | |||
| Handler: mux, | |||
| ErrorLog: zap.NewStdLog(log), | |||
| ReadHeaderTimeout: 5 * time.Second, | |||
There was a problem hiding this comment.
I am not certain that the ReadHeaderTimeout value is set correctly. We may wish to update it.
faddat
force-pushed
the
faddat/lint-relayer
branch
from
e7f57e7
to
b937c42
Compare
|
hey @faddat as of today we have officially merged the changes necessary to upgrade the relayer to ibc-go v8, cometbft v0.38.0 and sdk v0.50.1, (see #1312 where I gave you a shoutout), thanks for all your help on that! should we take another stab at getting the golangci configuration in line with the ibc-go repo's? if you are still interested in taking on this task my only ask would be that we break the PR up into a series of smaller PRs that are easier to review. I'm thinking maybe something like this:
Sorry if this sounds like a lot but it's really hard to give a thorough review when there are so many changes across so many files and I want to be sure that I can provide a solid review for your hard work! I haven't actually tried linting the repo with the updated golangci.yml file here so I'm not sure how many issues it turns up, perhaps what i'm asking for is completely unreasonable if there are like 100 different types of linter errors. In that case feel free to address a bunch of them in one PR, but it would be nice if we could keep each PR limited to like 250 LOC changes. As always thanks for your contributions! If you no longer wanna take this on i can cherry-pick some of your commits into a new branch and give you credit, just let me know 🙂 |
|
Closing this PR as stale. |
This PR lints the go relayer in the same manner as ibc-go before another PR to upgrade to sdk 50 and ibc8