feat: add separate flag for metrics #1504
Open
+579
−70
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AntiTyping
force-pushed
the
andy/feat/add-separate-flag-for-metrics
branch
from
709729a
to
17a9b80
Compare
|
Just saying, 9100 is a default port for node_exporter, which is widely used everywhere for HW metrics collection, so it might clash. |
Reecepbcups
reviewed
Sep 17, 2024
Reecepbcups
changed the title
jtieri
reviewed
Sep 17, 2024
* uses metrics-listen-addr for metrics server * sets default debug server api-listen-addr to 127.0.0.1:5183 * sets default metrics server metrics-listen-addr to 127.0.0.1:9100
* moves metrics to separate server
* removes address flags so config file is the source of truth for addresses * adds tests for flags to enable debug and metrics servers * adds tests for config file settings for addresses for debug and metrics servers * adjusts log messages
AntiTyping
force-pushed
the
andy/feat/add-separate-flag-for-metrics
branch
2 times, most recently
from
f2318fa
to
6edcf5c
Compare
AntiTyping
force-pushed
the
andy/feat/add-separate-flag-for-metrics
branch
from
6edcf5c
to
ec7bb41
Compare
* restores address flags * renames `--debug-addr` to `--debug-listen-addr` to be consistent with config file setting `debug-listen-addr:` * renames `--metrics-addr` to `--metrics-listen-addr` to be consistent with config file setting `metrics-listen-addr:` * updates docs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactors debug and metrics servers into two separate servers
--enable-metrics-servermetrics-listen-addrsetting to config.yamlrly config initwill generate the following configapi-listen-addrtodebug-listen-addr--debug-addrto--debug-listen-addrto be consistent with config