fix: updating timeout to use clienttypes.Height instead of uint64 #483
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
seantking
requested review from
AdityaSripal,
colin-axner and
fedekunze
as code owners
colin-axner
approved these changes
Mar 30, 2021
|
this closes #481 . It is the solution I was hoping for |
colin-axner
reviewed
Mar 30, 2021
colin-axner
added a commit
that referenced
this pull request
Apr 14, 2021
* fix: updating timeout to use clienttypes.Height instead of uint64 * Update relayer/ibc-client.go * Update relayer/naive-strategy.go * Update relayer/naive-strategy.go Co-authored-by: colin axnér <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the building and unpacking of ibc packets to use the same
clienttypes.Heighttype rather than referencing only theRevisionHeightwhich is auint64.Presently, for IBC application developers it is not possible to specify that timeout height should not be used as we always add version when rebuilding the packet before relaying ->
relayer/relayer/msgs.go
Line 378 in 76eb658
This PR allows for an IBC application to pass
clienttypes.ZeroHeightas timeoutHeight when building an IBC packet. The relayer will then ignore timeoutHeight as intended.@colin-axner short term solution for #481 ?