Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added BlockExternal and AllowList/DenyList importer interfaces #152

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

rabits
Copy link
Contributor

@rabits rabits commented Nov 27, 2023

This change allows you to control gomacro interpreter behavior for imports - you can simply disable the loading of external modules (block go get) and define Allow and Block lists to not much mess with imports.Packages.

Fixes: #151

@rabits
Copy link
Contributor Author

rabits commented Dec 3, 2023

Hi @cosmos72 , sorry to bother again but maybe you missed this change I created to close #151 ?

@cosmos72
Copy link
Owner

cosmos72 commented Dec 6, 2023

I have seen this PR, thanks.
The idea is useful: it just needs some (minor) improvements, I'll merge it ASAP

@rabits
Copy link
Contributor Author

rabits commented Dec 23, 2023

Hi @cosmos72 , maybe I can help with the minor improvements you've mentioned? What kind of changes you would like to see before merging it?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Way to disable go get import and enforce to use only defined import list
2 participants