Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix CI #317

Closed
wants to merge 4 commits into from
Closed

Fix CI #317

wants to merge 4 commits into from

Conversation

Schneegans
Copy link
Member

The windows CI finds the wrong version of glut. This attempts to fix this...

@Schneegans Schneegans added this to the Version 1.7.0 milestone Nov 29, 2022
@coveralls
Copy link

coveralls commented Nov 29, 2022

Pull Request Test Coverage Report for Build 3600052296

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 2.934%

Totals Coverage Status
Change from base Build 3513272209: 0.0%
Covered Lines: 491
Relevant Lines: 16734

💛 - Coveralls

@Schneegans
Copy link
Member Author

@JonasGilg: Do you have an idea what could be going on here? The windows builds suddenly started to find some weird version of freeglut (see here: https://github.com/cosmoscout/cosmoscout-vr/actions/runs/3572835896/jobs/6006182952#step:6:59). Now I tried to modify our find script so that it does not look into system paths and it finds the correct version again (https://github.com/cosmoscout/cosmoscout-vr/actions/runs/3574455560/jobs/6016382446#step:6:59). However, now the CI job fails to execute the cosmoscout.exe (https://github.com/cosmoscout/cosmoscout-vr/actions/runs/3574455560/jobs/6016382446#step:7:8).

@JonasGilg
Copy link
Member

If I convert the exit code to HEX (C0000139), it becomes the code for "entry point not found". It can't load one of the DLLs. Could it be, that it still tries to load the Starberry Freeglut DLL, which was compiled with a different MSVC version?

@Schneegans
Copy link
Member Author

Here's the issue: actions/runner-images#5459

Having an entire MinGW distribution in the PATH causes all sorts of problems depending on DLL search path order and files being searched for. I have seen problems due to Strawberry Perl pop up consistently, from linkers picking up incompatible libraries, but also hard-to-debug application crashes because executables loaded some incompatible DLL from the Strawberry Perl path. Even CMake is configuring Strawberry Perls libraries when compiling for MSVC

I am not sure how to fix this though. Mybe try to remove the Strawberry Perl?

@Schneegans
Copy link
Member Author

Following this discussion: actions/runner-images#6627, it seems that this issue may get fixed in the coming week.

@Schneegans
Copy link
Member Author

I am closing this as this will be fixed automatically.

@Schneegans Schneegans closed this Dec 2, 2022
@Schneegans Schneegans deleted the feature/fix-ci branch December 2, 2022 09:39
@Schneegans Schneegans removed this from the Version 1.7.0 milestone Dec 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants