Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

unify makefile #103

Merged
merged 1 commit into from
Nov 1, 2017
Merged

unify makefile #103

merged 1 commit into from
Nov 1, 2017

Conversation

vixentael
Copy link
Collaborator

@vixentael vixentael commented Nov 1, 2017

unify makefile: add install, install_all, test_all commands

similar to
cossacklabs/themis#248

@vixentael vixentael self-assigned this Nov 1, 2017
@@ -37,10 +37,13 @@ temp_copy:
@GOPATH=$(ABS_TEMP_GOPATH) go get github.com/cossacklabs/acra/cmd/...


build: temp_copy
install: temp_copy
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

here make install do not the same as in other our products. here it will copy binaries to REPO_DIR/build (

BIN_PATH = build
) when other our products place binaries to /usr/lib/*. I think we should install acra binaries to /usr/bin as default
and after changing path is important to drop this command -

acra/Makefile

Line 48 in fa860a2

@rm -rf $(BIN_PATH)
and explicitly list all binaries that should be deleted (acraproxy, acraserver, acra_genkeys, acra_rollback, acra_genpoisonrecord, acra_addzone) or it will delete /usr/bin folder when user will run sudo make clean :)

@vixentael
Copy link
Collaborator Author

as result we decided that it's okay to install acra to the local folder using make install, because "normal users" will use go get github.com/cossacklabs/acra/cmd/... that will install acra according to their environment

@vixentael vixentael merged commit f6ff358 into master Nov 1, 2017
@vixentael vixentael deleted the vixentael/makefile-acra branch November 1, 2017 17:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants