smessage integration #293
Merged
smessage integration #293
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
Lagovas
commented
Jan 24, 2018
Lagovas
commented
- each themis module tested separately
- secure messages tested in encryption and signing mode
- completed other integration suits (some cross-language tests wasn't added and that why decided to split them and add table of supported links of languages)
fix echo messages
vixentael
reviewed
Jan 24, 2018
|
|
||
| ## with context | ||
| echo ".. testing secure cell, seal mode context, php <--> python" | ||
| python ./tests/_integration/scell_seal_string_echo.py "dec" "passwd" `php -f ./tests/_integration/scell_seal_string_echo.php "enc" "passwd" "ruby->python seal with context" "somecontext"` "somecontext" |
vixentael
reviewed
Jan 24, 2018
| python ./tests/_integration/scell_seal_string_echo.py "dec" "passwd" `php -f ./tests/_integration/scell_seal_string_echo.php "enc" "passwd" "ruby->python seal with context" "somecontext"` "somecontext" | ||
| check_result_zero | ||
| echo ".. testing secure cell, seal mode, python <--> php" | ||
| php -f ./tests/_integration/scell_seal_string_echo.php "dec" "passwd" `python ./tests/_integration/scell_seal_string_echo.py "enc" "passwd" "python->ruby seal with context" "somecontext"` "somecontext" |
vixentael
reviewed
Jan 24, 2018
| ruby ./tests/_integration/smessage_encryption.rb "verify" "./tests/_integration/keys/server.priv" "./tests/_integration/keys/client.pub" `go run ./tests/_integration/smessage_encryption.go "sign" "./tests/_integration/keys/client.priv" "./tests/_integration/keys/server.pub" "go -> python secure message"` | ||
| check_result_zero | ||
| echo ".. testing secure message, ruby <--> go" | ||
| go run ./tests/_integration/smessage_encryption.go "verify" "./tests/_integration/keys/server.priv" "./tests/_integration/keys/client.pub" `ruby ./tests/_integration/smessage_encryption.rb "sign" "./tests/_integration/keys/client.priv" "./tests/_integration/keys/server.pub" "ruby secure message"` |
vixentael
reviewed
Jan 24, 2018
| @@ -0,0 +1,6 @@ | |||
| # | python | go | ruby | js | php | |||
There was a problem hiding this comment.
it's helped me to distribute such checklist across other scripts
but if you think it's unnecessary I will drop it
vixentael
approved these changes
Jan 24, 2018
Closed
vixentael
added
tests
ilammy
added
the
W-JsThemis 🍭
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.