Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

preserve hash (aka URL fragment) on version change #184

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

mojavelinux
Copy link
Contributor

No description provided.

@osfameron
Copy link
Contributor

@RichardSmedley I've built to staging, what do you think?

I think it probably isn't what we want. e.g. if you go to Java 3.6 Relnotes, then choose 3.5, you end up at https://docs-staging.couchbase.com/java-sdk/3.6/project-docs/sdk-release-notes.html#java-sdk-3-5-releases which does indeed keep the 3.5 relnotes visible, which probably isn't what we want.

We'd probably want to take the fragment from the selected nav option instead?

@RichardSmedley
Copy link
Contributor

Not sure I follow - whichever thing I click through to on staging is working as expected.

Perhaps we can go through this quickly after the meeting later?

@RichardSmedley
Copy link
Contributor

Aha - yes, not working the way we need it.
This is not the fix that we want. :-(

@mojavelinux
Copy link
Contributor Author

This strikes me as a design issue. You will need to decide what behavior you want. Once you can describe the behavior precisely, I can assist with with technical implementation. But I cannot decide for you how it should work.

@osfameron
Copy link
Contributor

@mojavelinux absolutely. Thanks for looking at it, I think your patch was useful to help us get some clarity on that.

Richard and I didn't yet come to agreement on definitive spec, and I'm not sure how urgent this remaining bit is -- but we'll come back to you if we can firm it up!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants