CBG-3895 add xattrsToDelete as a separate argument #120
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
torcolvin
commented
Apr 25, 2024
torcolvin
commented
- specify deleted xattrs in a separate argument to avoid accidental deletion of xattrs by setting a map value to nil
- make sure that users can not set xattrs to nil since this is not supported in rosmar (stores json as binary doesn't differentiate between not existent and nil)
- create error types to catch issues in rosmar, sync gateway
This was referenced Apr 25, 2024
adamcfraser
approved these changes
Apr 26, 2024
adamcfraser
reviewed
May 1, 2024
torcolvin
force-pushed
the
CBG-3895
branch
2 times, most recently
from
2a87026
to
c9417d8
Compare
- specify deleted xattrs in a separate argument to avoid accidental deletion of xattrs by setting a map value to nil - make sure that users can not set xattrs to nil since this is not supported in rosmar (stores json as binary doesn't differentiate between not existent and nil) - create error types to catch issues in rosmar, sync gateway
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.