Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CBG-2938: Ignore Cbgt EOF feed errors when intentionally stopped #6235

Merged
merged 2 commits into from
May 12, 2023
Merged

CBG-2938: Ignore Cbgt EOF feed errors when intentionally stopped #6235

merged 2 commits into from
May 12, 2023

Conversation

bbrks
Copy link
Member

@bbrks bbrks commented May 11, 2023 •
edited
Loading

CBG-2938

  • Changed CbgtContext.StopHeartbeatListener to CbgtContext.Stop
  • Made event handler context cancellable from Stop
  • Made OnFeedError callback check context for cancellation before logging about EOF

Pre-review checklist

  • Removed debug logging (fmt.Print, log.Print, ...)
  • Logging sensitive data? Make sure it's tagged (e.g. base.UD(docID), base.MD(dbName))
  • Updated relevant information in the API specifications (such as endpoint descriptions, schemas, ...) in docs/api

Integration Tests

@bbrks bbrks requested a review from torcolvin May 11, 2023 13:59
torcolvin
torcolvin reviewed May 11, 2023
View reviewed changes
Copy link
Collaborator

@torcolvin torcolvin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM otherwise

db/import_listener.go Show resolved Hide resolved
base/dcp_sharded.go Show resolved Hide resolved
@torcolvin torcolvin assigned bbrks and unassigned torcolvin May 11, 2023
@bbrks bbrks assigned torcolvin and unassigned bbrks May 11, 2023
adamcfraser
adamcfraser requested changes May 11, 2023
View reviewed changes
base/dcp_sharded.go Show resolved Hide resolved
@bbrks bbrks assigned adamcfraser and unassigned torcolvin May 11, 2023
@adamcfraser adamcfraser merged commit b9a08ed into master May 12, 2023
@adamcfraser adamcfraser deleted the CBG-2938 branch May 12, 2023 20:20
torcolvin pushed a commit that referenced this pull request May 30, 2023
@bbrks @torcolvin
CBG-2938: Ignore Cbgt EOF feed errors when intentionally stopped (#6235)
ba197b9 
* Use sgMgrEventHandlers context to add cancellation handling for EOF feed errors

* Move all importListener.Stop cbgtContext code into CbgtContext.Stop()
torcolvin pushed a commit that referenced this pull request May 30, 2023
@bbrks @torcolvin
CBG-2938: Ignore Cbgt EOF feed errors when intentionally stopped (#6235)
ffa4052 
* Use sgMgrEventHandlers context to add cancellation handling for EOF feed errors

* Move all importListener.Stop cbgtContext code into CbgtContext.Stop()
@torcolvin torcolvin mentioned this pull request May 30, 2023
Merged
4 tasks
bbrks added a commit that referenced this pull request Mar 28, 2024
@bbrks
CBG-2938: Ignore Cbgt EOF feed errors when intentionally stopped (#6235)
daa56c3 
* Use sgMgrEventHandlers context to add cancellation handling for EOF feed errors

* Move all importListener.Stop cbgtContext code into CbgtContext.Stop()
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@torcolvin torcolvin torcolvin left review comments

@adamcfraser adamcfraser adamcfraser approved these changes

Assignees

@adamcfraser adamcfraser

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bbrks @torcolvin @adamcfraser