Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[AV-69652] Adding cluster on/off schedule resource #167

Merged
merged 49 commits into from
Mar 29, 2024
Merged

[AV-69652] Adding cluster on/off schedule resource #167

merged 49 commits into from
Mar 29, 2024

Conversation

Talina06
Copy link
Member

@Talina06 Talina06 commented Mar 14, 2024 •
edited by PaulomeeCb
Loading

Jira

  • AV-69652

Description

Contains implementation for Cluster on/off schedule only.

Type of Change

  • Bug fix (non-breaking change which fixes an issue). Please, add the "bug" label to the PR.
  • New feature (non-breaking change which adds functionality). Please, add the "enhancement" label to the PR.
  • Breaking change (fix or feature that would cause existing functionality to not work as expected). Please, add the "breaking change" label to the PR.
  • This change requires a documentation update
  • Documentation fix/enhancement

Manual Testing Approach

How was this change tested and do you have evidence? (REQUIRED: Select at least 1)

  • Manually tested
  • Unit tested
  • Acceptance tested
  • Unable to test / will not test (Please provide comments in section below)

Testing

1. CREATE and LIST

terraform plan-
Screen Shot 2024-03-27 at 12 25 26 AM
Screen Shot 2024-03-27 at 12 29 05 AM

terraform apply-
Screen Shot 2024-03-27 at 12 33 30 AM
Screen Shot 2024-03-27 at 12 34 17 AM
Screen Shot 2024-03-27 at 12 34 39 AM
Screen Shot 2024-03-27 at 12 34 54 AM
Screen Shot 2024-03-27 at 12 35 32 AM
Screen Shot 2024-03-27 at 12 35 47 AM

Cluster on/off schedule created on UI-
Screen Shot 2024-03-27 at 12 29 36 AM

2. UPDATE

Changed values in .tfvars file

terraform plan-
Screen Shot 2024-03-27 at 12 42 06 AM
Screen Shot 2024-03-27 at 12 42 21 AM
Screen Shot 2024-03-27 at 12 42 31 AM
Screen Shot 2024-03-27 at 12 42 45 AM

terraform apply-
Screen Shot 2024-03-27 at 12 44 51 AM
Screen Shot 2024-03-27 at 12 44 59 AM
Screen Shot 2024-03-27 at 12 45 07 AM
Screen Shot 2024-03-27 at 12 45 22 AM

Values updated-
Screen Shot 2024-03-27 at 12 45 41 AM

3. IMPORT
Screen Shot 2024-03-27 at 1 00 24 AM

terraform plan-
Screen Shot 2024-03-27 at 1 02 36 AM

  1. DESTROY
Screen Shot 2024-03-27 at 1 05 14 AM Screen Shot 2024-03-27 at 1 05 24 AM Screen Shot 2024-03-27 at 1 05 30 AM Screen Shot 2024-03-27 at 1 05 42 AM Screen Shot 2024-03-27 at 1 05 48 AM

Required Checklist:

  • I have checked that this change does not generate any credentials and that they are NOT accidentally logged anywhere.
  • I have added tests that prove my fix is effective or that my feature works per HashiCorp requirements
  • I have added any necessary documentation (if required)
  • I have run make fmt and formatted my code

Further comments

Talina06 and others added 27 commits February 28, 2024 13:06
@Talina06
Add schema files and function structures
3af0124
@Talina06
Update the CRUD functions for onoff schedule
6c9762c
@Talina06
Update func logic for retrieve onoff schedule
e30f5a2
@Talina06
Merge branch 'main' of github.com:couchbasecloud/terraform-provider-c…
1208017 
…ouchbase-capella into AV-69652_cluster_appservices_on_off_feature
@PaulomeeCb
Updating examples/readme
0b7bda1
@PaulomeeCb
Updating docs/index.md
997c198
@PaulomeeCb
removing changes done to docs
936cb5c
@PaulomeeCb
Merge branch 'main' into AV-69652_cluster_appservices_on_off_feature
9475479
@PaulomeeCb
Reverting changes for activation state from cluster and appservice sc…
99b7f70 
…hema
@PaulomeeCb
Updating example folder
51ec00b
@PaulomeeCb
Updating .tfvars and variables
bc9b93f
@PaulomeeCb
Reverting doc changes
f32d8e7
@PaulomeeCb
Reverting doc changes
4a4ee95
@PaulomeeCb
Merge remote-tracking branch 'origin/AV-69652_cluster_appservices_on_…
90cbe4c 
…off_feature' into AV-69652_cluster_appservices_on_off_feature

# Conflicts:
#	docs/index.md
@PaulomeeCb
Merge remote-tracking branch 'origin/AV-69652_cluster_appservices_on_…
abcb3c7 
…off_feature' into AV-69652_cluster_appservices_on_off_feature
@PaulomeeCb
Merge remote-tracking branch 'origin/AV-69652_cluster_appservices_on_…
fd10735 
…off_feature' into AV-69652_cluster_appservices_on_off_feature

# Conflicts:
#	docs/index.md
@PaulomeeCb
Merge remote-tracking branch 'origin/AV-69652_cluster_appservices_on_…
c284b1b 
…off_feature' into AV-69652_cluster_appservices_on_off_feature
@PaulomeeCb
Merge remote-tracking branch 'origin/AV-69652_cluster_appservices_on_…
1ce7a90 
…off_feature' into AV-69652_cluster_appservices_on_off_feature
@PaulomeeCb
add docs/index.md
6272dcb
@PaulomeeCb
Updating examples
0c77646
@PaulomeeCb
Updating the example
19e182b
@PaulomeeCb
formatting
ed9e164
@PaulomeeCb
lint
0e8398b
@PaulomeeCb
formatting
c109c46
@PaulomeeCb
Updating get example
f2e89fd
@PaulomeeCb
Adding to datasources
e1ea58a
@PaulomeeCb
Adding condition for catching 404
a0dc1e6
@PaulomeeCb PaulomeeCb marked this pull request as ready for review March 27, 2024 08:37
@PaulomeeCb PaulomeeCb requested review from a team as code owners March 27, 2024 08:37
@PaulomeeCb PaulomeeCb changed the title [AV-69652] Cluster & Appservices on/off Feature [AV-69652] Adding cluster on/off schedule resource Mar 27, 2024
PaulomeeCb
PaulomeeCb previously approved these changes Mar 29, 2024
View reviewed changes
@PaulomeeCb PaulomeeCb self-requested a review March 29, 2024 23:18
@PaulomeeCb PaulomeeCb merged commit 263121b into main Mar 29, 2024
3 checks passed
@Talina06 Talina06 deleted the AV-69652_cluster_appservices_on_off_feature branch April 2, 2024 03:05
@Talina06 Talina06 added the no-changelog-needed This is a change not to be tracked in the changelog label Apr 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PaulomeeCb PaulomeeCb PaulomeeCb approved these changes

@SaicharanCB SaicharanCB Awaiting requested review from SaicharanCB

Assignees

@PaulomeeCb PaulomeeCb

Labels
no-changelog-needed This is a change not to be tracked in the changelog
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Talina06 @SaicharanCB @PaulomeeCb