Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update example readmes #177

Merged
merged 1 commit into from
Mar 26, 2024
Merged

Update example readmes #177

merged 1 commit into from
Mar 26, 2024

Conversation

Lagher0
Copy link
Contributor

@Lagher0 Lagher0 commented Mar 18, 2024

Jira

  • AV-75060

Description

Updating example readmes

Type of Change

  • Bug fix (non-breaking change which fixes an issue). Please, add the "bug" label to the PR.
  • New feature (non-breaking change which adds functionality). Please, add the "enhancement" label to the PR.
  • Breaking change (fix or feature that would cause existing functionality to not work as expected). Please, add the "breaking change" label to the PR.
  • This change requires a documentation update
  • Documentation fix/enhancement

Manual Testing Approach

How was this change tested and do you have evidence? (REQUIRED: Select at least 1)

  • Manually tested
  • Unit tested
  • Acceptance tested
  • Unable to test / will not test (Please provide comments in section below)

Testing

Testing

Required Checklist:

  • I have checked that this change does not generate any credentials and that they are NOT accidentally logged anywhere.
  • I have added tests that prove my fix is effective or that my feature works per HashiCorp requirements
  • I have added any necessary documentation (if required)
  • I have run make fmt and formatted my code

Further comments

@Lagher0 Lagher0 self-assigned this Mar 18, 2024
@Lagher0 Lagher0 marked this pull request as ready for review March 18, 2024 15:37
@Lagher0 Lagher0 requested review from a team as code owners March 18, 2024 15:37
l0n3star
l0n3star previously approved these changes Mar 18, 2024
@l0n3star l0n3star dismissed their stale review March 18, 2024 15:50

should not merge

@Talina06 Talina06 merged commit 0fe6af3 into main Mar 26, 2024
4 checks passed
@Talina06 Talina06 deleted the Update_readme branch March 26, 2024 17:26
@Talina06 Talina06 added the no-changelog-needed This is a change not to be tracked in the changelog label Apr 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
no-changelog-needed This is a change not to be tracked in the changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants