Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AV-87077 | handle computed values in acc test #227

Merged
merged 1 commit into from
Sep 20, 2024
Merged

Conversation

l0n3star
Copy link
Contributor

@l0n3star l0n3star commented Sep 20, 2024

Jira

Description

Acceptance giving false negative. Corrected to handle computed values.

Type of Change

  • Bug fix (non-breaking change which fixes an issue). Please, add the "bug" label to the PR.
  • New feature (non-breaking change which adds functionality). Please, add the "enhancement" label to the PR.
  • Breaking change (fix or feature that would cause existing functionality to not work as expected). Please, add the "breaking change" label to the PR.
  • This change requires a documentation update
  • Documentation fix/enhancement

Manual Testing Approach

How was this change tested and do you have evidence? (REQUIRED: Select at least 1)

  • Manually tested
  • Unit tested
  • Acceptance tested
  • Unable to test / will not test (Please provide comments in section below)

Testing

Testing
TF_ACC=1 go test -timeout=20m -run TestAccAuditLogExportTestCases
raw state map[%:17 audit.%:5 audit.created_at:2024-09-20 01:07:44.068119723 +0000 UTC audit.created_by:N4hqAQZX376Vlo9kQ8mxxzPxvhVX5QCp audit.modified_at:2024-09-20 01:09:39.511170175 +0000 UTC audit.modified_by:apikey-apikey-N4hqAQZX376Vlo9kQ8mxxzPxvhVX5QCp audit.version:5 availability.%:1 availability.type:multi cloud_provider.%:3 cloud_provider.cidr:10.0.6.0/24 cloud_provider.region:us-east-1 cloud_provider.type:aws configuration_type:multiNode connection_string:cb.ss1xws4sr1d7dn.customsubdomain.nonprod-project-avengers.com couchbase_server.%:1 couchbase_server.version:7.6 current_state:healthy description:terraform audit log export test cluster etag:Version: 5 id:60eefe78-3b58-4587-8048-6b846c117735 name:terraform audit log export test cluster organization_id:6af08c0a-8cab-4c1c-b257-b521575c16d0 project_id:311611bd-e6e7-4e3c-8dc7-4646d780f2fb service_groups.#:1 service_groups.0.%:3 service_groups.0.node.%:2 service_groups.0.node.compute.%:2 service_groups.0.node.compute.cpu:4 service_groups.0.node.compute.ram:16 service_groups.0.node.disk.%:4 service_groups.0.node.disk.iops:3000 service_groups.0.node.disk.storage:50 service_groups.0.node.disk.type:gp3 service_groups.0.num_of_nodes:3 service_groups.0.services.#:1 service_groups.0.services.0:data support.%:2 support.plan:enterprise support.timezone:PT]PASS
ok  	github.com/couchbasecloud/terraform-provider-couchbase-capella/internal/resources/acceptance_tests	277.757s

Required Checklist:

  • I have checked that this change does not generate any credentials and that they are NOT accidentally logged anywhere.
  • I have added tests that prove my fix is effective or that my feature works per HashiCorp requirements
  • I have added any necessary documentation (if required)
  • I have run make fmt and formatted my code
  • I have made sure that no schema field is marked with both requiresReplace and computed

Further comments

@l0n3star l0n3star requested review from a team as code owners September 20, 2024 01:16
@l0n3star l0n3star self-assigned this Sep 20, 2024
Copy link
Collaborator

@a-atri a-atri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@a-atri a-atri merged commit a6c7938 into main Sep 20, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants