This repository has been archived by the owner on Dec 13, 2019. It is now read-only.
[High Roller] Add getPlayerRolls function to HighRollerApp #2341
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This splits the highRoller function into two functions for the client
Alonski
added
📦 Contracts
snario
approved these changes
Sep 6, 2019
1 task
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This splits the highRoller function into two functions for the client. Currently, the client calls the highRoller function which returns the total of two dice rolls.
Then it splits that up for the UI to show.
This is incorrect. For example a die roll of 1 and 6 will be shown in the UI as 3 and 4.
The code on the client:
https://github.com/counterfactual/dapps-bots/blob/master/packages/dapp-high-roller/src/components/app-root/app-root.tsx#L212
Related issues
Relates to: counterfactual/dapps-bots#22