This repository has been archived by the owner on Dec 13, 2019. It is now read-only.
Remove legacy events from Node #2381
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
snario
force-pushed
the
liam/eventsAreMessageHandlers
branch
from
8717944
to
24ec730
Compare
snario
force-pushed
the
liam/eventsAreMessageHandlers
branch
from
24ec730
to
19f46d6
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Put this together very quickly on the plane. The event concept was introduced when the codebase was first started by @cf19drofxots but doesn't match the concept of what it really does very well.
This begins to fix it.
TODO
DEPOSIT_CONFIRMEDevent which atm is a message sent from the caller to the receiver. Doesn't automatically happen because there is no "deposit protocol"