[WIP] Courier key type #61
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kchen-coursera
commented
Apr 25, 2017
| @@ -36,7 +36,8 @@ object Courier extends Build with OverridablePublishSettings { | |||
|
|
|||
| override lazy val settings = super.settings ++ overridePublishSettings ++ | |||
| Seq( | |||
| organization := "org.coursera.courier") | |||
| organization := "org.coursera.courier", | |||
| isSnapshot := true) | |||
There was a problem hiding this comment.
this is important to ensure that all local changes are published for testing
kchen-coursera
commented
Apr 25, 2017
| @@ -469,9 +473,24 @@ private UnionDataSchema parseUnion( | |||
| return schema; | |||
| } | |||
|
|
|||
| private RecordDataSchema parseRecord( | |||
| private RecordDataSchema parseKey( | |||
There was a problem hiding this comment.
We likely have to copy RecordDataSchema since it's final or decorate it with additional annotations so we don't erase type information of the new key keyword. It's also one possible place we can add some validation to make sure the courier document conforms to spec
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sample code changes for supporting new ID type. There are quite a bit of work still missing namely: