Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add scala version override for 3.5.0-RC1 #229

Merged
merged 1 commit into from
May 21, 2024
Merged

Conversation

bishabosha
Copy link
Contributor

@bishabosha bishabosha commented May 13, 2024

This should wait until we confirm that 3.5.0-RC1 is uploaded to GitHub

part of scala/scala3#20098

also depends on users upgrading coursier due to coursier/coursier#2975

Copy link
Collaborator

@tgodzik tgodzik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, could you remind me about merging it?

@bishabosha
Copy link
Contributor Author

ok seems like we should also wait for the release to be marked as not-draft

@bishabosha
Copy link
Contributor Author

@tgodzik this can now be merged - the release was marked not draft

@tgodzik tgodzik merged commit 0c82a99 into coursier:main May 21, 2024
1 check passed
@tgodzik
Copy link
Collaborator

tgodzik commented May 21, 2024

@bishabosha bishabosha deleted the patch-4 branch May 21, 2024 18:12
@bishabosha
Copy link
Contributor Author

great, its working!

~ » cs install scala:3.5.0-RC1                             jamie@Jamies-MBP
Wrote scala
----------------------------------------------------------------------------
~ » scala -version                                         jamie@Jamies-MBP
Scala code runner version: 1.3.1
Scala version (default): 3.5.0-RC1

@tgodzik
Copy link
Collaborator

tgodzik commented May 21, 2024

Thanks @bishabosha for the great work!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants