feat: local testing framework and swapAndBridge example #9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
meetmangukiya
changed the title
mfw78
reviewed
May 25, 2024
examples/swapAndBridge.ts
Outdated
| target: USDC, | ||
| callData: fnCalldata( | ||
| 'approve(address,uint256)', | ||
| ABI_CODER.encode(['address', 'uint'], [GNOSIS_CHAIN_BRIDGE, buyAmount]) |
There was a problem hiding this comment.
nit: note that as it is a sell order, there may be at least buyAmount, but there may actually be more than buyAmount...
There was a problem hiding this comment.
Additionally, please make consistent use of specifying the bitwidth of uint (i.e. no uint, use uint256 🙏 )
There was a problem hiding this comment.
yeah, was a conscious choice, surplus will just stay in the user controlled proxy
examples/swapAndBridge.ts
Outdated
| ); | ||
| const hooks = { | ||
| post: [ | ||
| { target: factory, callData: hooksCalldata, gasLimit: '1000000000' }, |
There was a problem hiding this comment.
I think the example should methodology for determining a sane gasLimit (note that given the use of ecrecover within the signature verification, the gas used isn't fixed)
There was a problem hiding this comment.
added provider.estimateGas but its gonna fail for the posthooks usually since those tokens wont exist on the proxy at that point.
meetmangukiya
force-pushed
the
encoding-sdk
branch
from
394b7d9
to
a9330df
Compare
mfw78
approved these changes
May 28, 2024
mfw78
approved these changes
May 28, 2024
mfw78
reviewed
May 28, 2024
| }; | ||
|
|
||
| // encode the input part of the weiroll command | ||
| export const encodeInput = ( |
There was a problem hiding this comment.
It would be great to understand what all these are (without specific reference to weiroll docs)
examples/swapAndBridge.ts
Outdated
Comment on lines
91
to
92
| encodeInput( | ||
| encodeInputArg(true, 0), |
There was a problem hiding this comment.
nit: describe what this is doing. Write it long hand in comments. Developers should be able to reference this example and have minimum additional work required to understand what is happening so they can then apply it to their own use case.
Comment on lines
+93
to
+97
| END_OF_ARGS, | ||
| END_OF_ARGS, | ||
| END_OF_ARGS, | ||
| END_OF_ARGS, | ||
| END_OF_ARGS |
There was a problem hiding this comment.
Why this? a simple comment would help
| END_OF_ARGS, | ||
| END_OF_ARGS | ||
| ), | ||
| encodeInputArg(true, 1), |
| END_OF_ARGS | ||
| ), | ||
| encodeInputArg(true, 1), | ||
| USDC |
There was a problem hiding this comment.
Assuming this is the target, document as such
| END_OF_ARGS, | ||
| END_OF_ARGS | ||
| ), | ||
| END_OF_ARGS, |
There was a problem hiding this comment.
Why is this different to the previous? Assuming this is because the output doesn't have to be put somewhere, but document it as such
examples/swapAndBridge.ts
Outdated
Comment on lines
119
to
123
| const state = [ | ||
| hexZeroPad(proxyAddress, 32), // address to query the balance of | ||
| '0x', // this is where balance output will be written | ||
| hexZeroPad(USDC, 32), // USDC token address | ||
| ]; |
There was a problem hiding this comment.
Explain in more detail what is happening here. It's not clear why the balanceOf is in the previous weiroll commands, but then there is state here.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduces common utilities for anvil setup, contracts deployment, funding, creating and settling orders, etc. And an example to swap and bridge using these utilties.