Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[1.43] No pop-up when cancel a parent order #2898

Closed
elena-zh opened this issue Jul 18, 2023 · 0 comments · Fixed by #2914
Closed

[1.43] No pop-up when cancel a parent order #2898

elena-zh opened this issue Jul 18, 2023 · 0 comments · Fixed by #2914
Assignees
@shoom3301
Labels
app:CowSwap CowSwap app Bug Something isn't working Low Severity indicator for defects. It won't cause any major break-down of the system TWAP twap-1.43

Comments

@elena-zh
Copy link

Reported in #2884 (comment) (case 4)

  1. Place a TWAP order
  2. Once the order is signed and executed, cancel it
  3. Wait till the TX is executed

AR: Cancelling sound is playing w/o a cancelled pop-up

ER: Cancelled pop-up should be present
@elena-zh elena-zh added app:CowSwap CowSwap app Bug Something isn't working Low Severity indicator for defects. It won't cause any major break-down of the system TWAP twap-1.43 labels Jul 18, 2023
This was referenced Jul 18, 2023
Merged
Merged
@shoom3301 shoom3301 self-assigned this Jul 19, 2023
@shoom3301 shoom3301 mentioned this issue Jul 19, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@shoom3301 shoom3301

Labels
app:CowSwap CowSwap app Bug Something isn't working Low Severity indicator for defects. It won't cause any major break-down of the system TWAP twap-1.43
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(twap): display popup when order is cancelled cowprotocol/cowswap
2 participants
@shoom3301 @elena-zh