Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(twap): add recipient to summary in cancel modal #2904

Merged
merged 1 commit into from
Jul 19, 2023
Merged

feat(twap): add recipient to summary in cancel modal #2904

merged 1 commit into from
Jul 19, 2023

Conversation

nenadV91
Copy link
Contributor

@nenadV91 nenadV91 commented Jul 18, 2023 •
edited
Loading

Summary

Fixes #2887

This adds a recipient to TWAP orders cancelation modal and popups.

Cancel confirmation modal
Screenshot 2023-07-18 at 14 02 09

To test

  • I've tested it in cancel confirmation modal but not in the popups since I couldn't get them.
  • Test in cancel confirm modal and in popups

@vercel
Copy link

vercel bot commented Jul 18, 2023 •
edited by github-actions bot
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
swap-dev ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 18, 2023 0:27am

@nenadV91 nenadV91 requested review from a team July 18, 2023 12:19
@shoom3301 shoom3301 added the TWAP label Jul 18, 2023
@elena-zh
Copy link

Hey @nenadV91 , cancelling modals, plus cancel a part pop-ups look good to me!
As for the pop-up when cancel a parent order, it is not displayed, and there is #2898 task for this.

However, looks like the issue with 'Expired' pop-up is not fixed here. Could you please take a look at it?

elena-zh
elena-zh approved these changes Jul 19, 2023
View reviewed changes
Copy link

@elena-zh elena-zh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have created #2913 task for the Expired pop-up

@nenadV91 nenadV91 merged commit 13d67fe into develop Jul 19, 2023
13 of 14 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Jul 19, 2023
@alfetopito alfetopito deleted the 2887/add-recipient-to-cancel branch July 19, 2023 14:33
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@alfetopito alfetopito alfetopito approved these changes

@shoom3301 shoom3301 shoom3301 approved these changes

@elena-zh elena-zh elena-zh approved these changes

Assignees
No one assigned
Labels
TWAP
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[1.42]No recipient in the Cancelled/Expired pop-up for TWAP order
4 participants
@nenadV91 @elena-zh @alfetopito @shoom3301