Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do not make unnecesary requests #3

Closed
anxolin opened this issue Apr 2, 2022 · 0 comments
Closed

Do not make unnecesary requests #3

anxolin opened this issue Apr 2, 2022 · 0 comments
Labels
app:CowSwap CowSwap app wontfix Stale issue

Comments

@anxolin
Copy link
Contributor

anxolin commented Apr 2, 2022

We still have some hooks that make requests we don't need.
We should cleanup unnecesary logic, like the claiming logic.

example:

Original issue gnosis/cowswap#111 by @anxolin
@anxolin anxolin added wontfix Stale issue app:CowSwap CowSwap app labels Apr 2, 2022
shoom3301 added a commit that referenced this issue Sep 19, 2022
@shoom3301
Merge pull request #1038 from cowprotocol/refactor/wrap-native-token
06c42a4 
[SWAP REFACTORING #3] refactor wrap/unwrap flow
shoom3301 added a commit that referenced this issue Mar 6, 2023
@shoom3301
Merge pull request #2082 from cowprotocol/sdk-dogfooding/order-book-3
e8965a0 
[#3] SDK dogfooding, getNativePrice, sendOrder, sendSignedOrderCancellation
@anxolin anxolin closed this as completed Jul 24, 2023
@shoom3301 shoom3301 mentioned this issue Sep 7, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
app:CowSwap CowSwap app wontfix Stale issue
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@anxolin