Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: remove walletConnect v1 and use v2 by default #3156

Merged
merged 4 commits into from
Oct 2, 2023

Conversation

shoom3301
Copy link
Collaborator

Summary

Context: https://cowservices.slack.com/archives/C0375NV72SC/p1695724802482379

Looks like V2 is already well-supported and we even started receiving warnings about using V1.
So, it's time to remove V1 and use V2 by default.

To Test

  1. There is no V1 in the wallets list
  2. V2 is available without feature-flag
  3. Alpha, Ambire and Trust icons are using V2

@shoom3301 shoom3301 requested a review from a team September 26, 2023 12:21
@shoom3301 shoom3301 self-assigned this Sep 26, 2023
@vercel
Copy link

vercel bot commented Sep 26, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
swap-dev ✅ Ready (Inspect) Visit Preview Sep 29, 2023 11:14am

🌃 Cosmos ↗︎

Copy link
Collaborator

@alfetopito alfetopito left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One last nitpick.

Since we do not have another option, might as well remove the tooltip?

image

@shoom3301
Copy link
Collaborator Author

@alfetopito thanks! Removed the tooltip

@shoom3301 shoom3301 merged commit 4b3fbc0 into develop Oct 2, 2023
6 of 7 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Oct 2, 2023
@alfetopito alfetopito deleted the feat/remove-wc-v1 branch October 3, 2023 09:16
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants