-
Notifications
You must be signed in to change notification settings - Fork 89
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: remove walletConnect v1 and use v2 by default #3156
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
shoom3301
force-pushed
the
feat/remove-wc-v1
branch
from
September 26, 2023 12:23
2d1e63c
to
23efe12
Compare
shoom3301
force-pushed
the
feat/remove-wc-v1
branch
from
September 26, 2023 12:24
23efe12
to
db3e8cb
Compare
anxolin
approved these changes
Sep 26, 2023
alfetopito
reviewed
Sep 26, 2023
apps/cowswap-frontend/src/modules/wallet/containers/WalletModal/index.tsx
Show resolved
Hide resolved
apps/cowswap-frontend/src/modules/wallet/pure/StatusIcon/index.tsx
Outdated
Show resolved
Hide resolved
alfetopito
approved these changes
Sep 28, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@alfetopito thanks! Removed the tooltip |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Context: https://cowservices.slack.com/archives/C0375NV72SC/p1695724802482379
Looks like V2 is already well-supported and we even started receiving warnings about using V1.
So, it's time to remove V1 and use V2 by default.
To Test