Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: iterate on configurator #3364

Merged
merged 2 commits into from
Nov 9, 2023
Merged

Conversation

fairlighteth
Copy link
Contributor

@fairlighteth fairlighteth commented Nov 8, 2023

Summary

  • General reiterations configurator
Screen.Recording.2023-11-08.at.16.57.57.mov

@fairlighteth fairlighteth requested a review from a team November 8, 2023 17:02
Copy link

vercel bot commented Nov 8, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
cosmos ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 9, 2023 6:07pm
swap-dev ✅ Ready (Inspect) Visit Preview Nov 9, 2023 6:07pm
widget-configurator ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 9, 2023 6:07pm

Copy link
Contributor

@anxolin anxolin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

const LINKS = [
{ icon: <LanguageIcon />, label: 'Widget web', url: `https://cow.fi/widget/?${UTM_PARAMS}` },
{ icon: <ChromeReaderModeIcon />, label: 'Developer docs', url: `https://docs.cow.fi/?${UTM_PARAMS}` },
]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we move the URLs to a const?

* feat: move embed code button

* feat: add snackbar click to copy (#3366)

* feat: add snackbar click to copy

* feat: snackbar set timeout to 3s

* feat: revert click away and font fix

* feat: embed code button styling

* feat: embed code button refactor

* feat: remove comments
@fairlighteth
Copy link
Contributor Author

Consolidated waterfall PR, with the latest being #3366 (comment)

Copy link
Contributor

@anxolin anxolin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

only comment is if we should delete fontsource/inter if we don't use it

@anxolin anxolin merged commit c4ba4bb into release/1.49.0 Nov 9, 2023
10 of 11 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Nov 9, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants