feat: add snackbar click to copy #3366
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
anxolin
reviewed
Nov 8, 2023
There was a problem hiding this comment.
It's great!
If i nitpick. I find the contrast not super readable. Green letter on green background.
Also, normally the click feedback is not absolut positioned. Would it make sense to position it relative to the button the user clicks so the feedback is right there?
in case it helps:
https://stackoverflow.com/questions/75371693/is-it-possible-to-align-mui-snackbar-relative-to-its-parent-div-rather-than-to
disregard both comments if you think they are not good suggestions.
shoom3301
approved these changes
Nov 9, 2023
|
Refactored code:
|
|
Merging, please review at your convenience post merge. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Screen.Recording.2023-11-08.at.17.56.10.mov