Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

2440/uni merge: request to switch network is not sent after a wallet connection #340

Closed
anxolin opened this issue Apr 2, 2022 · 4 comments · Fixed by #406
Closed

2440/uni merge: request to switch network is not sent after a wallet connection #340

anxolin opened this issue Apr 2, 2022 · 4 comments · Fixed by #406
Labels
app:CowSwap CowSwap app Bug Something isn't working Medium Severity indicator. It causes some undesirable behavior, but the system is still functional

Comments

@anxolin
Copy link
Contributor

anxolin commented Apr 2, 2022

Related to #2536

  1. Open the app
  2. Select Rinkeby network (or any other)
  3. Make sure that Rinkeby is not selected in the MM (f.e. GC)
  4. Connect to the MM wallet

AR: the app is connected to GC, no request to switch network to Rinkeby

ER: request to change a network to Rinkeby is sent to MM right after conneciton

Original issue gnosis/cowswap#2627 by @elena-zh

@anxolin anxolin added Medium Severity indicator. It causes some undesirable behavior, but the system is still functional app:CowSwap CowSwap app Bug Something isn't working labels Apr 2, 2022
This was referenced Apr 4, 2022
@elena-zh
Copy link

I have to reopen the issue. Due to the issue is still here: When 'Gnosis Chain' (f.e.) is selected in the network selector, and when I press on the Connect wallet button, I'm not connected to Gnosis Chain network, but to the network that is selected in the connected wallet (in my case, to Rinkeby).
And there is no request to connect to GC after the wallet connection.
See the video: https://watch.screencastify.com/v/jSK61uDnt6oqk9DDITMx

@elena-zh elena-zh reopened this Apr 19, 2022
@anxolin
Copy link
Contributor Author

anxolin commented Apr 22, 2022

I'm not sure about this one. So when you connect it takes the network from the connected wallet. Only if you change it later it CowSwap it will require the change in MM.

I can see arguments why your proposal is better for some cases, but in some others maybe I would prefer to make my wallet ditacte the network and not the other way around.

This is currently the behaviour in Uniswap, so for now I wouldn't change it unless we get some strong feedback

@elena-zh
Copy link

@anxolin , the issue is created due to it works this way in our Cowswap app in Prod now. So the behavior will be changed after Uni merge goes live.
But anyways, we can close this issue and leave it as it is.

@anxolin
Copy link
Contributor Author

anxolin commented Apr 27, 2022

Okay, anyways, thanks for rising it. It was a good option, but I think as it is, is good enough, and is the lesser effort for the team

@anxolin anxolin closed this as completed Apr 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
app:CowSwap CowSwap app Bug Something isn't working Medium Severity indicator. It causes some undesirable behavior, but the system is still functional
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants