2440/uni merge #374
Merged
2440/uni merge #374
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* feat: mv block number to atom * fix: add block updater * fix: fast forward dep
* feat: mv block number to atom * fix: add block updater * fix: fast forward dep * refactor: mv multicall to lib * feat: add multicall to widget * chore: update widget deps * nit: pluralize updaters * chore: minimize deps
* refactor: mv token list utils to lib * refactor: mv balance hooks to lib * feat: interactive token select
* refactor: mv gas estimate chains out of component * chore: replace microbundle with rollup * chore: use ts rollup config * chore: rename lib to widgets * chore: add rollup doc comment * feat: rollup typings * fix: retain tsconfig decl dir
* add survey popup for survey monkey * update useEffect and add 24 hour window * upate % logic * update logic to show after duration * update timestamp conditional * small changes
* refactor: mv useNativeCurrency to lib/hooks * refactor: mv useCurrency logic to lib/hooks
* fix: token image for chains / natives * feat: include native currency in select - Updates widgets swap state to use Currency (and deals with downstream updates) - Refactors logoURI code to a new lib/hooks/useCurrencyLogoURIs - Adds native currency to useQueryTokenList NB: This does not build because tests must be updated to use Currency (they currently use mock tokens) * test: update fixtures to use real currency * fix: data uri color extraction * fix: token img state * fix: use new array
* fix: memoize derived swap info * fix: memoize current block timestamp * fix: memoize price impact * fix: memoize debounced value updates * fix: nits
… and Missing provider error (#3110) * add error reporting component, INTEGRATION ERROR type, and Missing provider error * rename reporter to generator * pr feedback * refactor provider check * add chainId, convenienceFee, and width errors * pr feedback and convenienceFeeRecipient address enforcement * fix imports for utils
* refactor: mv settings state to own file * chore: add default exports * refactor: update swap state to match biz logic * feat: copy biz logic to widgets * Hook up UI to updated swap state * fix: decimal inputs * fix max slippage * fix error in settings * fix: typing errors * revert: useBestTrade changes * fix: use client side trade for widgets * fix: exhaustive deps * chore: add router-sdk * fix: gate old web3 on widget env * fix building errors * update trade imports * update hook naming for swap amount and currencies * small changes Co-authored-by: Zach Pomerantz <[email protected]>
* feat: filter selected currency from select * test: use infura urls * fix: load native with chain * fix: use currencyId for key * feat: switch currencies when selecting other * fix: resolve merge conflict name
|
CLA Assistant Lite: I have read the CLA Document and I hereby sign the CLA 0 out of 9 committers have signed the CLA. |
|
ah fucks sake. sorry uni team |
|
APPROVED (i manually opened this so cant self review) |
|
|
This was referenced Apr 13, 2022
Merged
|
When I press on the 'Buy COW' button, I see that 'Select token' in the From field is missing: |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
(recreating from gnosis/cowswap#2529)
Closes gnosis/cowswap#2440
Merge with latest from original UNI code
PR deployment URL https://pr2536--gpswapui.review.gnosisdev.com/
TO DOs
List of things that I know we should look at. There might be more...
To Test
TEST EVERYTHING!!