feat(swap): display order hooks details #4925
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… feat/hooks-iframe-app # Conflicts: # apps/cowswap-frontend/src/modules/hooksStore/hooks/usePostHooksRecipientOverride.ts # apps/cowswap-frontend/src/modules/hooksStore/hooks/useSetRecipientOverride.ts # apps/cowswap-frontend/src/modules/hooksStore/types/hooks.ts # apps/cowswap-frontend/src/modules/trade/hooks/useResetRecipient.ts
…l/cowswap into feat/hooks-iframe-app-1
…col/cowswap into feat/hooks-iframe-app-2
…col/cowswap into feat/hooks-iframe-app-3
…col/cowswap into feat/hooks-iframe-app-4
…col/cowswap into feat/hooks-iframe-app-5
…col/cowswap into feat/hooks-iframe-app-6
…col/cowswap into feat/hooks-iframe-app-7
…col/cowswap into feat/hooks-iframe-app-8
… feat/hooks-iframe-app
…l/cowswap into feat/hooks-iframe-app-1 # Conflicts: # apps/cowswap-frontend/src/modules/trade/hooks/useNotifyWidgetTrade.ts
…col/cowswap into feat/hooks-iframe-app-3
…col/cowswap into feat/hooks-iframe-app-4
…col/cowswap into feat/hooks-iframe-app-6
…col/cowswap into feat/hooks-iframe-app-8
Co-authored-by: Leandro <[email protected]>
… feat/hook-to-dapp-matching
…otocol/cowswap into feat/hook-to-dapp-matching-explorer # Conflicts: # libs/hook-dapp-lib/package.json
…com/cowprotocol/cowswap into feat/hook-to-dapp-matching-cowswap
…4928) * feat(hooks-store): update custom hook-dapps manifests periodically * chore: fix memo isDarkMode * chore: fix code style
alfetopito
reviewed
Oct 2, 2024
Comment on lines
+154
to
+158
| {(children) => ( | ||
| <ConfirmDetailsItem label="Hooks" tooltip="Hooks are interactions before/after order execution."> | ||
| {children} | ||
| </ConfirmDetailsItem> | ||
| )} |
There was a problem hiding this comment.
Similar comment to the explorer changes: fn children instead of flat JSX
There was a problem hiding this comment.
But we need it here in order to wrap the content into ConfirmDetailsItem.
Also, Michel changed it a bit in his PR
Base automatically changed from
feat/hook-to-dapp-matching-explorer
to
develop
October 2, 2024 13:46
… feat/hook-to-dapp-matching-cowswap # Conflicts: # apps/cowswap-frontend/src/modules/hooksStore/pure/AddCustomHookForm/CustomDappLoader/index.tsx # libs/hook-dapp-lib/src/utils.ts
alfetopito
approved these changes
Oct 4, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Displaying of order hook details.
UI is not ready yet and will be implemented in another PR!
To Test
No need to test (please test all recent changes all together when design for hook details is ready)