Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add styling for hooksitems in review modal #4932

Merged
merged 114 commits into from
Oct 4, 2024
Merged

feat: add styling for hooksitems in review modal #4932

merged 114 commits into from
Oct 4, 2024

Conversation

fairlighteth
Copy link
Contributor

Summary

  • Adds styling for hook items in the review modal
Screenshot 2024-10-01 at 12 04 30 Screenshot 2024-10-01 at 12 04 38 Screenshot 2024-10-01 at 12 04 50 Screenshot 2024-10-01 at 12 05 03 Screenshot 2024-10-01 at 12 05 14 Screenshot 2024-10-01 at 12 05 24

shoom3301 and others added 30 commits September 12, 2024 14:14
@shoom3301
feat(hooks-store): add order params and signer to hook dapp context
cbd8fa0
@shoom3301
feat(hooks-store): setup blank app for iframe hook
d02ed5b
@shoom3301
refactor: generalise CowEventEmitter in order to reuse it in hook dapps
56e303d
@shoom3301
feat: iframe transport library
21b4c01
@shoom3301
feat: use iframe-transport lib for widget
87c424f
@shoom3301
feat: hook-dapp-lib for hook-dapps in iframe
f1a256a
@shoom3301
feat(hooks-store): add omnibridge hook-dapp via iframe
f0f438a
@shoom3301
Merge branch 'develop' of https://github.com/cowprotocol/cowswap into…
21c194a 
… feat/hooks-iframe-app

# Conflicts:
#	apps/cowswap-frontend/src/modules/hooksStore/hooks/usePostHooksRecipientOverride.ts
#	apps/cowswap-frontend/src/modules/hooksStore/hooks/useSetRecipientOverride.ts
#	apps/cowswap-frontend/src/modules/hooksStore/types/hooks.ts
#	apps/cowswap-frontend/src/modules/trade/hooks/useResetRecipient.ts
@shoom3301
Merge branch 'feat/hooks-iframe-app' of https://github.com/cowprotoco…
e000886 
…l/cowswap into feat/hooks-iframe-app-1
@shoom3301
Merge branch 'feat/hooks-iframe-app-1' of https://github.com/cowproto…
46544e0 
…col/cowswap into feat/hooks-iframe-app-2
@shoom3301
Merge branch 'feat/hooks-iframe-app-2' of https://github.com/cowproto…
086ad26 
…col/cowswap into feat/hooks-iframe-app-3
@shoom3301
Merge branch 'feat/hooks-iframe-app-3' of https://github.com/cowproto…
5990bbd 
…col/cowswap into feat/hooks-iframe-app-4
@shoom3301
Merge branch 'feat/hooks-iframe-app-4' of https://github.com/cowproto…
4ae2f76 
…col/cowswap into feat/hooks-iframe-app-5
@shoom3301
Merge branch 'feat/hooks-iframe-app-5' of https://github.com/cowproto…
ffeb18c 
…col/cowswap into feat/hooks-iframe-app-6
@shoom3301
Merge branch 'feat/hooks-iframe-app-6' of https://github.com/cowproto…
ecbe52b 
…col/cowswap into feat/hooks-iframe-app-7
@shoom3301
Merge branch 'feat/hooks-iframe-app-7' of https://github.com/cowproto…
64ef4c6 
…col/cowswap into feat/hooks-iframe-app-8
@shoom3301
Merge branch 'develop' of https://github.com/cowprotocol/cowswap into…
896a856 
… feat/hooks-iframe-app
@shoom3301
Merge branch 'feat/hooks-iframe-app' of https://github.com/cowprotoco…
5a610da 
…l/cowswap into feat/hooks-iframe-app-1

# Conflicts:
#	apps/cowswap-frontend/src/modules/trade/hooks/useNotifyWidgetTrade.ts
@shoom3301
Merge branch 'feat/hooks-iframe-app-1' of https://github.com/cowproto…
e5b74c5 
…col/cowswap into feat/hooks-iframe-app-3
@shoom3301
chore: specify key
50fa90a
@shoom3301
Merge branch 'feat/hooks-iframe-app-3' of https://github.com/cowproto…
1158709 
…col/cowswap into feat/hooks-iframe-app-4
@shoom3301
Merge branch 'feat/hooks-iframe-app-4' of https://github.com/cowproto…
7ebe545 
…col/cowswap into feat/hooks-iframe-app-6
@shoom3301
docs: doc @cowprotocol/hook-dapp-lib
d594f60
@shoom3301
chore: revert ff
d88b805
@shoom3301
Merge branch 'feat/hooks-iframe-app-6' of https://github.com/cowproto…
6939abf 
…col/cowswap into feat/hooks-iframe-app-8
@shoom3301
refactor: simplify hooks store state
5baf090
@shoom3301
chore: fix build
2ce7906
@shoom3301
chore: fix build
313e53f
@shoom3301
chore: remove boilerplate
66a93b3
@shoom3301 @alfetopito
Update libs/hook-dapp-lib/README.md
3bc7a22 
Co-authored-by: Leandro <[email protected]>
@elena-zh
Copy link

elena-zh commented Oct 3, 2024

Hey @shoom3301 , great, thank you!
One more issue I've faced: explorer shows 0 (or 00) in the Hooks field when no hooks added.
Reproducible for all orders (swaps/limit/twaps):

  1. No post-hook:
    image

  2. No hooks at all:
    00

@elena-zh
Copy link

elena-zh commented Oct 3, 2024

Also, still there are some issues for @fairlighteth to address:

  1. When only pre-hook is added to an order, 'pre' label is truncated in the Account modal
    1 hook
  2. It would be nice to Improve account modal view when hooks are added
    image
  3. Improve Explorer view:
    image

LMK please if I need to open a separate task for this

Base automatically changed from feat/hook-to-dapp-matching-cowswap to develop October 4, 2024 08:02
@shoom3301
Merge branch 'develop' of https://github.com/cowprotocol/cowswap into…
83bd30f 
… feat/hook-to-dapp-matching-cowswap-styling1

# Conflicts:
#	apps/cowswap-frontend/src/common/containers/OrderHooksDetails/HookItem/index.tsx
#	apps/cowswap-frontend/src/common/containers/OrderHooksDetails/HookItem/styled.tsx
#	apps/cowswap-frontend/src/common/containers/OrderHooksDetails/index.tsx
#	apps/cowswap-frontend/src/common/containers/OrderHooksDetails/styled.tsx
#	apps/cowswap-frontend/src/modules/trade/pure/TradeConfirmation/index.tsx
#	libs/hook-dapp-lib/src/utils.ts
@shoom3301
Copy link
Collaborator

When only pre-hook is added to an order, 'pre' label is truncated in the Account modal

@elena-zh @fairlighteth fixed that

@elena-zh elena-zh mentioned this pull request Oct 4, 2024
Open
elena-zh
elena-zh approved these changes Oct 4, 2024
View reviewed changes
Copy link

@elena-zh elena-zh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixes #4940 as well.
Approved.
For remaining issues I've opened #4945

@elena-zh elena-zh mentioned this pull request Oct 4, 2024
Closed
2 tasks
@shoom3301 shoom3301 merged commit 83184d2 into develop Oct 4, 2024
11 of 12 checks passed
@shoom3301 shoom3301 deleted the feat/hook-to-dapp-matching-cowswap-styling1 branch October 4, 2024 12:41
@github-actions github-actions bot locked and limited conversation to collaborators Oct 4, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@shoom3301 shoom3301 shoom3301 approved these changes

@elena-zh elena-zh elena-zh approved these changes

Assignees
No one assigned
Labels
Hooks store
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@fairlighteth @elena-zh @shoom3301