[SWAP REFACTORING #4.1] new swap page, setup layout #1043
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Important: example how to customize components - DestCurrencyInputPanel
anxolin
approved these changes
Sep 15, 2022
src/components/swap/SwapHeader.tsx
Outdated
| export default function SwapHeader({ allowedSlippage }: { allowedSlippage: Percent }) { | ||
| export default function SwapHeader({ | ||
| allowedSlippage, | ||
| className = '', |
There was a problem hiding this comment.
Curious why we use empty string as the default when className is optional and can be undefined
src/custom/pages/NewSwap/index.tsx
Outdated
| const { allowedSlippage } = useDerivedSwapInfo() | ||
|
|
||
| return ( | ||
| <styledEl.Container> |
There was a problem hiding this comment.
shouldn't the swap widget composition be inside a component instead of the page?
There was a problem hiding this comment.
I moved it because AffiliateStatusCheck component is out of boundaries
[SWAP REFACTORING #5] code review fixes
[SWAP REFACTORING #4.5] new swap page, cosmos fixtures and documentation
[SWAP REFACTORING #4.4] new swap page, merge develop, code cleanup
[SWAP REFACTORING #4.3] new swap page, recipient controls, trade rates, high slippage warning
[SWAP REFACTORING #4.2] new swap page, bind data rendering and logic
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
https://docs.google.com/document/d/1QCuT2zT-G7fKB5azLmssj8O3yd2dwBpDuoRJuz0cw0U/edit#
How to review
Sorry for the big PR, for easier code review, please review per commit, starting with the oldest
Refactoring PR's list:
4.1. Setup layout
4.2. Bind data rendering and logic
4.3. Recipient controls, trade rates, high slippage warning
4.4. Merge develop, code cleanup
4.5. Cosmos fixtures and documentation
Testing
Don't test this PR, test the final PR - New swap page