chore: update embedded widget codebase #2707
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
New and updated dependency changes detected. Learn more about Socket for GitHub ↗︎
Footnotes |
| HOME: '/', | ||
| SWAP: `/:chainId?${TRADE_WIDGET_PREFIX}/swap/:inputCurrencyId?/:outputCurrencyId?`, | ||
| LIMIT_ORDER: `/:chainId?${TRADE_WIDGET_PREFIX}/limit-orders/:inputCurrencyId?/:outputCurrencyId?`, | ||
| ADVANCED_ORDERS: `/:chainId?${TRADE_WIDGET_PREFIX}/advanced-orders/:inputCurrencyId?/:outputCurrencyId?`, |
There was a problem hiding this comment.
aha, ok, so you reuse the routes, cool!
|
|
||
| if (isDarkMode === darkModeRef.current) return | ||
|
|
||
| dispatch(updateUserDarkMode({ userDarkMode: isDarkMode })) |
There was a problem hiding this comment.
in some other params, we remove the param from the URL once used. Not saying we should do it here, just wondering if it makes sense
There was a problem hiding this comment.
For now this param is only for widget where we don't see a URL of iframe. But I see what you mean, probably we would need to clean up the URL
| @@ -7,9 +7,9 @@ import { Identify, identify, init, track } from '@amplitude/analytics-browser' | |||
| * member of the organization on Amplitude to view details. | |||
| */ | |||
| export function initializeAnalytics(isDevEnvironment = process.env.NODE_ENV === 'development') { | |||
| const API_KEY = process.env.REACT_APP_AMPLITUDE_KEY | |||
| if (isDevEnvironment || !API_KEY) return | |||
| if (isDevEnvironment) return | |||
There was a problem hiding this comment.
I added this cause testing locally in "production mode" would break herre, and i would think is not a mandatory param, right?
There was a problem hiding this comment.
Yes, I just inherited it from the previous branch
There was a problem hiding this comment.
I'm bringing this back, since it breaks the e2e #2733
Summary
serveconfiguration for Vite