Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(twap): update ComposableCoW contract #2724

Merged
merged 1 commit into from
Jun 29, 2023
Merged

feat(twap): update ComposableCoW contract #2724

merged 1 commit into from
Jun 29, 2023

Conversation

shoom3301
Copy link
Collaborator

@shoom3301 shoom3301 commented Jun 27, 2023 •
edited
Loading

Summary

Fixes #2639

New addresses:

  • ExtensibleFallbackHandler 0x4e305935b14627eA57CBDbCfF57e81fd9F240403
  • ComposableCoW 0xF487887DA5a4b4e3eC114FDAd97dc0F785d72738
  • TWAP 0x910d00a310f7Dc5B29FE73458F47f519be547D3d
  • CurrentBlockTimestampFactory 0x0899c7DC280363d263Cc954506134F249CceC4a5

What changed:

  1. Changed the call of ComposableCoW.create to ComposableCoW.createWithContext
  2. Added appData to TWAP order
  3. Added usage of CurrentBlockTimestampFactory to set a block timestamp as TWAP order startTime

To Test

  1. Should create a TWAP order as before
  2. Should check and change Fallback handler as before
  3. Should display a valid appData in Explorer for part-orders

@shoom3301 shoom3301 added the TWAP label Jun 27, 2023
@shoom3301 shoom3301 requested review from a team June 27, 2023 08:11
@shoom3301 shoom3301 self-assigned this Jun 27, 2023
@vercel
Copy link

vercel bot commented Jun 27, 2023 •
edited by github-actions bot
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
swap-dev ✅ Ready (Inspect) Visit Preview 💬 Add feedback

🌃 Cosmos ↗︎

@shoom3301 shoom3301 merged commit c16d45a into develop Jun 29, 2023
@github-actions github-actions bot locked and limited conversation to collaborators Jun 29, 2023
@alfetopito alfetopito deleted the fix/2639 branch July 3, 2023 12:31
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees

@shoom3301 shoom3301

Labels
TWAP
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Deploy smart-contracts to all networks
1 participant
@shoom3301