Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(twap): pass order class and slippage to app-data #2778

Merged
merged 9 commits into from
Jul 6, 2023
Merged

feat(twap): pass order class and slippage to app-data #2778

merged 9 commits into from
Jul 6, 2023

Conversation

shoom3301
Copy link
Collaborator

Summary

Added a slippage value and orderClass=twap to appData

To Test

  1. Create a TWAP order
  2. Wait until the first part is created
  • Part order's app-data should contain orderClass=twap
  • Part order's app-data slippage should respect the entered value

@shoom3301 shoom3301 added the TWAP label Jul 3, 2023
@shoom3301 shoom3301 requested review from a team July 3, 2023 15:39
@shoom3301 shoom3301 self-assigned this Jul 3, 2023
@vercel
Copy link

vercel bot commented Jul 3, 2023 •
edited by github-actions bot
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
swap-dev ✅ Ready (Inspect) Visit Preview 💬 Add feedback

🌃 Cosmos ↗︎

@socket-security
Copy link

socket-security bot commented Jul 3, 2023 •
edited
Loading

Removed dependencies detected. Learn more about Socket for GitHub ↗︎

🚮 Removed packages: @cowprotocol/[email protected]

@elena-zh
Copy link

elena-zh commented Jul 4, 2023

I can't see part's app data on explorer
image

Also, I can't see it when I open it as a link https://cloudflare-ipfs.com/ipfs/QmcxSNSBbX8vmKR3vmeHvKZJuwkRkP33wgsYXB1VGu6ddv

But I have been able to see it in the console:
image

@shoom3301
Copy link
Collaborator Author

@elena-zh fixed

@elena-zh elena-zh mentioned this pull request Jul 5, 2023
Closed
elena-zh
elena-zh approved these changes Jul 5, 2023
View reviewed changes
Copy link

@elena-zh elena-zh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works great now.
I have created a task to add this order type into Explorer's AppData page
cowprotocol/explorer#544

@shoom3301
Merge branch 'develop' of https://github.com/cowprotocol/cowswap into…
f96e016 
… feat/app-data-twap-class

# Conflicts:
#	src/modules/application/containers/App/Updaters.tsx
@shoom3301 shoom3301 merged commit 096f729 into develop Jul 6, 2023
12 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Jul 6, 2023
@alfetopito alfetopito deleted the feat/app-data-twap-class branch July 6, 2023 08:48
alfetopito
alfetopito reviewed Jul 6, 2023
View reviewed changes
Copy link
Collaborator

@alfetopito alfetopito left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@alfetopito alfetopito alfetopito left review comments

@elena-zh elena-zh elena-zh approved these changes

Assignees

@shoom3301 shoom3301

Labels
TWAP
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@shoom3301 @elena-zh @alfetopito